Merge lp://qastaging/~florian-dacosta/openerp-product-attributes/custom_base_attribute_ref__build_attribute_field into lp://qastaging/~product-core-editors/openerp-product-attributes/7.0
Proposed by
Florian da Costa
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~florian-dacosta/openerp-product-attributes/custom_base_attribute_ref__build_attribute_field |
| Merge into: | lp://qastaging/~product-core-editors/openerp-product-attributes/7.0 |
| Diff against target: |
34 lines (+7/-3) 1 file modified
base_custom_attributes/custom_attributes.py (+7/-3) |
| To merge this branch: | bzr merge lp://qastaging/~florian-dacosta/openerp-product-attributes/custom_base_attribute_ref__build_attribute_field |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Laetitia Gangloff (Acsone) (community) | Needs Resubmitting | ||
| Product Core Editors | Pending | ||
|
Review via email:
|
|||
Description of the change
The function _build_
The goal of this merge is simply to replace this parameter by an attribute.
For example in my case, I am creating a module using attribute.attribute but I do not need to create attribute set or attribute group. In result, attribute.location dont exist so I can't use the _build_
To post a comment you must log in.
Revision history for this message
| Laetitia Gangloff (Acsone) (laetitia-gangloff) wrote | # |
review:
Needs Resubmitting
Unmerged revisions
- 238. By Florian da Costa
-
[REF] Refactore _build_
attribute_ field function so it takes an attribute.attribute as parameter instead of an attribute.location, because it is more generic
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This project is now hosted on https:/