Ubuntu Terminal App

Merge lp://qastaging/~flscogna/ubuntu-terminal-app/fix-1431558 into lp://qastaging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

  1. fix-1431558
  2. Merge into reboot
Proposed by Filippo Scognamiglio
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄
Approved revision: 66
Merged at revision: 66
Proposed branch: lp://qastaging/~flscogna/ubuntu-terminal-app/fix-1431558
Merge into: lp://qastaging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 155 lines (+79/-30)
2 files modified
src/app/qml/TerminalInputArea.qml (+20/-24)
src/app/qml/TerminalPage.qml (+59/-6)
To merge this branch: bzr merge lp://qastaging/~flscogna/ubuntu-terminal-app/fix-1431558
Reviewer Review Type Date Requested Status
Stefano Verzegnassi Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Terminal Developers Pending
Review via email: mp+253011@code.qastaging.launchpad.net

Commit message

Fix inconsistent scrolling behaviour.

Description of the change

Fix inconsistent scrolling behaviour.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:66
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/142/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2355
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2355/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/63
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-vivid-amd64-ci/26

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/142/rebuild

review: Approve (continuous-integration)
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

LGTM! Great work Filippo, this fixes the issue!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches