Merge lp://qastaging/~fourdollars/unity-settings-daemon/fix-lowest-brightness into lp://qastaging/unity-settings-daemon/14.04
Proposed by
Shih-Yuan Lee
| Status: | Rejected |
|---|---|
| Rejected by: | Iain Lane |
| Proposed branch: | lp://qastaging/~fourdollars/unity-settings-daemon/fix-lowest-brightness |
| Merge into: | lp://qastaging/unity-settings-daemon/14.04 |
| Diff against target: |
264 lines (+107/-23) 4 files modified
plugins/power/gpm-common.c (+1/-1) plugins/power/gsd-backlight-helper.c (+86/-17) plugins/power/gsd-backlight-linux.c (+13/-4) plugins/power/gsd-backlight-linux.h (+7/-1) |
| To merge this branch: | bzr merge lp://qastaging/~fourdollars/unity-settings-daemon/fix-lowest-brightness |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity Settings Daemon Development Team | Pending | ||
|
Review via email:
|
|||
Commit message
power: On raw backlight types, clamp the value to a minumum
Description of the change
Please help to review this change.
This change has been applied in xenial.
I am backporting it into trusty.
To post a comment you must log in.
Revision history for this message
| Iain Lane (laney) wrote | # |
Unmerged revisions
- 4049. By Shih-Yuan Lee
-
power: On raw backlight types, clamp the value to a minumum
Backlight class brightness 0 is to disable the backlight since kernel 3.18.
This behavior is by design for the backlight control in i915 kernel module.
http://lists.freedeskt op.org/ archives/ intel-gfx/ 2014-August/ 050642. html However gnome-settings-
daemon has included some changeset to fix this issue.
https://bugzilla. gnome.org/ show_bug. cgi?id= 744278 unity-settings-
daemon should include the same changeset to fix this issue. (LP: #1381625)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
You said on the bug that this isn't necessary, so closing it