Merge lp://qastaging/~francesco-marella/a4/i18n into lp://qastaging/a4
Proposed by
Francesco Marella
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 113 | ||||
| Proposed branch: | lp://qastaging/~francesco-marella/a4/i18n | ||||
| Merge into: | lp://qastaging/a4 | ||||
| Diff against target: |
389 lines (+216/-17) 8 files modified
a4lib/app.py (+10/-6) a4lib/i18n.py (+29/-0) data/a4.desktop.in (+3/-2) data/window_main.glade (+9/-9) po/LINGUAS (+1/-0) po/POTFILES.in (+14/-0) po/POTFILES.skip (+3/-0) po/a4.pot (+147/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~francesco-marella/a4/i18n | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrea Gasparini | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Francesco Marella (francesco-marella) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The old functionalities are ok, and strings are correct. Unfortunately I don't know enough the translation engine to make further tests, but to me the code is ok.
Just one remark (and a note for the merger), we usually try to keep the code clean with some tools.
A brief test with pep8 gives:
a4lib/i18n.py:12:1: E302 expected 2 blank lines, found 1
(It's just one blank line, I guess the one of us that will merge can correct this as well)