Merge lp://qastaging/~francesco-marella/redshift/autostart into lp://qastaging/~jonls/redshift/trunk

Proposed by Francesco Marella
Status: Merged
Merged at revision: 121
Proposed branch: lp://qastaging/~francesco-marella/redshift/autostart
Merge into: lp://qastaging/~jonls/redshift/trunk
Diff against target: 205 lines (+117/-0)
5 files modified
src/gtk-redshift/Makefile.am (+10/-0)
src/gtk-redshift/gtk-redshift.desktop (+11/-0)
src/gtk-redshift/rsappindicator.py (+15/-0)
src/gtk-redshift/statusicon.py (+15/-0)
src/gtk-redshift/utils.py (+66/-0)
To merge this branch: bzr merge lp://qastaging/~francesco-marella/redshift/autostart
Reviewer Review Type Date Requested Status
Jon Lund Steffensen Pending
Review via email: mp+26939@code.qastaging.launchpad.net

Commit message

Add a feature to toggle autostart on login (Francesco Marella)

Description of the change

Add a feature to toggle autostart on login

A launcher is placed in Applications -> Utility.
The user toggles autostart through the popup menu. The 'xdg' module is required.

Note: desktop file should be modified to be translatable.

To post a comment you must log in.
Revision history for this message
Jon Lund Steffensen (jonls) wrote :

Awesome. I'd like to wait with the merge until version 1.4 is out. I'm thinking that 1.5 could be released a few weeks later with this autostart patch and the options-in-configuration-file patch that I'm wokring on.

Revision history for this message
Jon Lund Steffensen (jonls) wrote :

Finally got around to testing this. I noticed that the check mark in autostart appears even when the desktop file can't be found. Can you fix this? I'll see if I can figure out how to make the desktop file translatable (gettext is sooo painful, ugh).

Revision history for this message
Francesco Marella (francesco-marella) wrote :

> Finally got around to testing this. I noticed that the check mark in autostart
> appears even when the desktop file can't be found. Can you fix this? I'll see
> if I can figure out how to make the desktop file translatable (gettext is sooo
> painful, ugh).
Noted, thanks. I'll release a fix ASAP.

105. By Francesco Marella

Disable autostart menu item when the desktop file can't be found

106. By Francesco Marella

utils.py: copy the desktop file in autostart folder

Revision history for this message
Francesco Marella (francesco-marella) wrote :

I did some testing and should be fixed now.
If the desktop file does not exists, the autostart menu item is disabled.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches