Redshift

Merge lp://qastaging/~francesco-marella/redshift/bug-588086-appindicator into lp://qastaging/~jonls/redshift/trunk

  1. bug-588086-appindicator
  2. Merge into trunk
Proposed by Francesco Marella
Status: Merged
Merged at revision: 102
Proposed branch: lp://qastaging/~francesco-marella/redshift/bug-588086-appindicator
Merge into: lp://qastaging/~jonls/redshift/trunk
Diff against target: 2639 lines (+2547/-10)
8 files modified
Makefile.am (+2/-1)
configure.ac (+24/-0)
data/icons/hicolor/scalable/apps/redshift-idle.svg (+2395/-0)
src/gtk-redshift/Makefile.am (+24/-4)
src/gtk-redshift/__init__.py (+0/-2)
src/gtk-redshift/gtk-redshift.in (+2/-2)
src/gtk-redshift/rsappindicator.py (+99/-0)
src/gtk-redshift/statusicon.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~francesco-marella/redshift/bug-588086-appindicator
Reviewer Review Type Date Requested Status
Jon Lund Steffensen Approve
Review via email: mp+26854@code.qastaging.launchpad.net

Commit message

Port gtk-redshift script to Application indicators. (Francesco Marella)

To post a comment you must log in.
Revision history for this message
Jon Lund Steffensen (jonls) wrote :

Looks good. What is the rationale behind commit 102 and 103?

Revision history for this message
Francesco Marella (francesco-marella) wrote :

> Looks good. What is the rationale behind commit 102 and 103?
commit 102: I'm lazy enough to update the __init__.py file with the selected module and after all filling the list __all__ is optional.

commit 103: I thought that wrapping only the main loop is enough to catch when the user hits the interrupt key. Am I wrong?

Revision history for this message
Jon Lund Steffensen (jonls) wrote :

> commit 103: I thought that wrapping only the main loop is enough to catch when
> the user hits the interrupt key. Am I wrong?

I think it is important not to leave a redshift process running in the background no matter when a user decides to hit CTRL-c. That's why I had the try block go back to right after the external process is started.

lp://qastaging/~francesco-marella/redshift/bug-588086-appindicator updated
105. By Francesco Marella

rvert commit 103: Wrap in try...except only gtk.main.

Revision history for this message
Francesco Marella (francesco-marella) wrote :

> > commit 103: I thought that wrapping only the main loop is enough to catch
> when
> > the user hits the interrupt key. Am I wrong?
>
> I think it is important not to leave a redshift process running in the
> background no matter when a user decides to hit CTRL-c. That's why I had the
> try block go back to right after the external process is started.

OK. Just reverted that commit.

Revision history for this message
Jon Lund Steffensen (jonls) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches