lp://qastaging/~frankban/charms/precise/juju-gui/clickjacking
- Get this branch:
- bzr branch lp://qastaging/~frankban/charms/precise/juju-gui/clickjacking
Branch merges
- charmers: Pending requested
-
Diff: 59 lines (+23/-1)4 files modifiedconfig/apache-site.template (+2/-0)
revision (+1/-1)
server/guiserver/handlers.py (+5/-0)
server/guiserver/tests/test_handlers.py (+15/-0)
Related bugs
Bug #1295264: jujugui allows iframing and can be clickjacked in this way | High | Fix Released |
Related blueprints
Branch information
- Owner:
- Francesco Banconi
- Status:
- Development
Recent revisions
- 179. By Francesco Banconi
-
Trusty charm.
Make the charm work on trusty.
Also update the charm documentation.QA:
Please run the unit and functional tests
using both precise and trusty.
Follow the instructions in the HACKING file.R=bac
CC=
https://codereview. appspot. com/88100044 - 176. By Francesco Banconi
-
Make the GUI server redirect to the default icon.
Create a specialized proxy handler for handling
Juju HTTP API requests. In this subclass, handle
the case a request is for a local charm icon
that cannot be found on the Juju server.Tests: `make unittest`.
QA:
- `juju bootstrap`;
- from the branch root, run `make deploy`;
- wait for the GUI service to be ready;
- switch to the trunk branch:
`juju set juju-gui juju-gui-source= develop`
- wait for the GUI to be ready;
- deploy local charms including an icon:
you should see the icons are correctly displayed in the
service blocks and inspector header;
- deploy a local charm not including an icon:
you should see the fallback icon displayed both in
the service block and the inspector;
- destroy the environment, done.R=bac
CC=
https://codereview. appspot. com/86100043 - 175. By Benji York
-
Handle broken nrpe relations.
R=frankban
CC=
https://codereview. appspot. com/76860047
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://qastaging/charms/juju-gui