Merge lp://qastaging/~frankban/charms/precise/juju-gui/enable-go-sandbox into lp://qastaging/~juju-gui/charms/precise/juju-gui/trunk

Proposed by Francesco Banconi
Status: Merged
Merged at revision: 99
Proposed branch: lp://qastaging/~frankban/charms/precise/juju-gui/enable-go-sandbox
Merge into: lp://qastaging/~juju-gui/charms/precise/juju-gui/trunk
Diff against target: 218 lines (+87/-58)
5 files modified
Makefile (+1/-1)
hooks/backend.py (+9/-14)
revision (+1/-1)
tests/20-functional.test (+9/-0)
tests/test_backends.py (+67/-42)
To merge this branch: bzr merge lp://qastaging/~frankban/charms/precise/juju-gui/enable-go-sandbox
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+183124@code.qastaging.launchpad.net

Description of the change

Enable sandbox mode in juju-core environments.

Also added a sandbox functional test and
improved the backend framework unit tests.

https://codereview.appspot.com/13424043/

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+183124_code.launchpad.net,

Message:
Please take a look.

Description:
Enable sandbox mode in juju-core environments.

Also added a sandbox functional test and
improved the backend framework unit tests.

https://code.launchpad.net/~frankban/charms/precise/juju-gui/enable-go-sandbox/+merge/183124

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/13424043/

Affected files:
   M Makefile
   A [revision details]
   M hooks/backend.py
   M revision
   M tests/20-functional.test
   M tests/test_backends.py

Revision history for this message
Richard Harding (rharding) wrote :
Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Enable sandbox mode in juju-core environments.

Also added a sandbox functional test and
improved the backend framework unit tests.

R=rharding
CC=
https://codereview.appspot.com/13424043

https://codereview.appspot.com/13424043/

Revision history for this message
Francesco Banconi (frankban) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches