Merge lp://qastaging/~frankban/charms/precise/juju-gui/invalid-pyjuju-ws into lp://qastaging/~juju-gui/charms/precise/juju-gui/trunk
Proposed by
Francesco Banconi
Status: | Merged |
---|---|
Merged at revision: | 101 |
Proposed branch: | lp://qastaging/~frankban/charms/precise/juju-gui/invalid-pyjuju-ws |
Merge into: | lp://qastaging/~juju-gui/charms/precise/juju-gui/trunk |
Diff against target: |
32 lines (+3/-3) 3 files modified
hooks/utils.py (+1/-1) revision (+1/-1) tests/test_utils.py (+1/-1) |
To merge this branch: | bzr merge lp://qastaging/~frankban/charms/precise/juju-gui/invalid-pyjuju-ws |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
charmers | Pending | ||
Review via email:
|
Description of the change
Fix WebSocket URL in pyJuju.
The WS URL must include the /ws path when
the GUI is connected to rapi.
To post a comment you must log in.
Reviewers: mp+183229_ code.launchpad. net,
Message:
Please take a look.
Description:
Fix WebSocket URL in pyJuju.
The WS URL must include the /ws path when
the GUI is connected to rapi.
https:/ /code.launchpad .net/~frankban/ charms/ precise/ juju-gui/ invalid- pyjuju- ws/+merge/ 183229
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/13432043/
Affected files:
A [revision details]
M hooks/utils.py
M revision
M tests/test_utils.py
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision:
<email address hidden>
+New revision:
<email address hidden>
Index: revision
=== modified file 'revision'
--- revision 2013-08-30 13:21:52 +0000
+++ revision 2013-08-30 15:41:34 +0000
@@ -1,1 +1,1 @@
-79
+80
Index: hooks/utils.py
is_legacy_ juju = legacy_juju() 127.0.0. 1:{}'.format( API_PORT) 127.0.0. 1:{}/ws' .format( API_PORT)
api_url = 'wss:// {}'.format( get_api_ address( ))
context. update( {
=== modified file 'hooks/utils.py'
--- hooks/utils.py 2013-08-26 15:53:22 +0000
+++ hooks/utils.py 2013-08-30 15:41:34 +0000
@@ -560,7 +560,7 @@
if not sandbox:
if is_legacy_juju:
- api_url = 'wss://
+ api_url = 'wss://
else:
Index: tests/test_utils.py test_utils. py'
guiserver_ conf = self.files[ 'guiserver. conf']
self. assertIn( 'description "GUIServer"', guiserver_conf)
self. assertIn( '--logging= "info"' , guiserver_conf) '--apiurl= "wss:// 127.0.0. 1:8080" ', guiserver_conf) '--apiurl= "wss:// 127.0.0. 1:8080/ ws"', guiserver_conf)
self. assertIn( '--apiversion= "python" ', guiserver_conf)
self. assertIn(
'--testsroot= "{}/test/ "'.format( JUJU_GUI_ DIR), guiserver_conf)
=== modified file 'tests/
--- tests/test_utils.py 2013-08-26 15:53:22 +0000
+++ tests/test_utils.py 2013-08-30 16:29:57 +0000
@@ -734,7 +734,7 @@
- self.assertIn(
+ self.assertIn(