Merge lp://qastaging/~frankban/juju-gui/bug-1229939-service-set into lp://qastaging/juju-gui/experimental

Proposed by Francesco Banconi
Status: Rejected
Rejected by: Francesco Banconi
Proposed branch: lp://qastaging/~frankban/juju-gui/bug-1229939-service-set
Merge into: lp://qastaging/juju-gui/experimental
Diff against target: 211 lines (+50/-61)
6 files modified
app/store/env/go.js (+10/-10)
app/store/env/sandbox.js (+26/-35)
test/test_env_go.js (+6/-8)
test/test_inspector_settings.js (+1/-1)
test/test_sandbox_go.js (+4/-4)
test/test_service_config_view.js (+3/-3)
To merge this branch: bzr merge lp://qastaging/~frankban/juju-gui/bug-1229939-service-set
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+187544@code.qastaging.launchpad.net

Description of the change

Fix settings update in juju-core.

When sending ServiceSet requests, the GUI included
a Config parameter where juju-core expects an
Option one.
While I was looking at that code, I decided instead to
switch to the newer ServiceUpdate API call, which
handles both map[string]string and YAML settings.

QA:
- deploy and expose the GUI in a juju-core env;
- switch to this branch:
    juju set juju-gui juju-gui-source=lp:~frankban/juju-gui/bug-1229939-service-set
- try to change settings (e.g. juju-gui-debug);
- refresh.

The settings viewlet should reflect the changes and,
after a while (after config-changed runs),
the new settings should be applied.

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+187544_code.launchpad.net,

Message:
Please take a look.

Description:
Fix settings update in juju-core.

When sending ServiceSet requests, the GUI included
a Config parameter where juju-core expects an
Option one.
While I was looking at that code, I decided instead to
switch to the newer ServiceUpdate API call, which
handles both map[string]string and YAML settings.

QA:
- deploy and expose the GUI in a juju-core env;
- switch to this branch:
     juju set juju-gui
juju-gui-source=lp:~frankban/juju-gui/bug-1229939-service-set
- try to change settings (e.g. juju-gui-debug);
- refresh.

The settings viewlet should reflect the changes and,
after a while (after config-changed runs),
the new settings should be applied.

https://code.launchpad.net/~frankban/juju-gui/bug-1229939-service-set/+merge/187544

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/13900044/

Affected files (+52, -61 lines):
   A [revision details]
   M app/store/env/go.js
   M app/store/env/sandbox.js
   M test/test_env_go.js
   M test/test_inspector_settings.js
   M test/test_sandbox_go.js
   M test/test_service_config_view.js

Revision history for this message
Francesco Banconi (frankban) wrote :

Unmerged revisions

1087. By Francesco Banconi

Checkpoint.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches