Merge lp://qastaging/~frankban/juju-quickstart/handle-gui-ports into lp://qastaging/juju-quickstart

Reviewers: mp+260032_code.launchpad.net,

Message:
Please take a look.

Description:
Handle Juju GUI server port.

The Juju GUI charm can be configured to listen
to customized ports (juju set juju-gui port=n).
This branch adds to quickstart the ability to
detect the port used by the GUI server, and
therefore connect to the right WebSocket and
Web URLs. Additionally handle the cases in which
the GUI is run in non secure mode.

Also add an option to deploy the GUI on a
customized port directly using quickstart.

Also add an hidden options (--gui-source)
intended for development use only. This allows
for building a specific GUI github branch
(e.g. frankban/my-feature-branch or juju/develop)
when installing the Juju GUI, and can be useful
while coding/QAing GUI branches.

Tests: `make check`.

QA:
- use the GUI as usual, to check for regressions:
   `devenv/bin/juju-quickstart`;
- change the juju-gui port and secure mode:
   `juju set juju-gui port=4242 secure=false`
- wait for the changes to take effect;
- use quickstart again to check that insecure mode
   and customized ports are detected:
   `devenv/bin/juju-quickstart`;
- destroy the environment;
- use quickstart again to server the GUI develop
   branch on a customized port:
   `devenv/bin/juju-quickstart --gui-port 8000 --gui-source
juju/develop`;
- check that everything works correctly;
- destroy the environment;
- done, thank you!

https://code.launchpad.net/~frankban/juju-quickstart/handle-gui-ports/+merge/260032

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/238540043/

Affected files (+642, -133 lines):
   A [revision details]
   M quickstart/__init__.py
   M quickstart/app.py
   A quickstart/jujugui.py
   M quickstart/jujutools.py
   M quickstart/manage.py
   M quickstart/platform_support.py
   M quickstart/tests/test_app.py
   M quickstart/tests/test_juju.py
   A quickstart/tests/test_jujugui.py
   M quickstart/tests/test_jujutools.py
   M quickstart/tests/test_manage.py
   M quickstart/tests/test_utils.py
   M quickstart/utils.py

Please take a look.

https://codereview.appspot.com/238540043/diff/1/quickstart/jujugui.py
File quickstart/jujugui.py (right):

https://codereview.appspot.com/238540043/diff/1/quickstart/jujugui.py#newcode59
quickstart/jujugui.py:59: def parse_charm_url(charm_url):
This function was just moved.

https://codereview.appspot.com/238540043/

LGTM QA okay! Thanks for the work on this

https://codereview.appspot.com/238540043/

*** Submitted:

Handle Juju GUI server port.

The Juju GUI charm can be configured to listen
to customized ports (juju set juju-gui port=n).
This branch adds to quickstart the ability to
detect the port used by the GUI server, and
therefore connect to the right WebSocket and
Web URLs. Additionally handle the cases in which
the GUI is run in non secure mode.

Also add an option to deploy the GUI on a
customized port directly using quickstart.

Also add an hidden options (--gui-source)
intended for development use only. This allows
for building a specific GUI github branch
(e.g. frankban/my-feature-branch or juju/develop)
when installing the Juju GUI, and can be useful
while coding/QAing GUI branches.

Tests: `make check`.

QA:
- use the GUI as usual, to check for regressions:
   `devenv/bin/juju-quickstart`;
- change the juju-gui port and secure mode:
   `juju set juju-gui port=4242 secure=false`
- wait for the changes to take effect;
- use quickstart again to check that insecure mode
   and customized ports are detected:
   `devenv/bin/juju-quickstart`;
- destroy the environment;
- use quickstart again to server the GUI develop
   branch on a customized port:
   `devenv/bin/juju-quickstart --gui-port 8000 --gui-source
juju/develop`;
- check that everything works correctly;
- destroy the environment;
- done, thank you!

R=
CC=
https://codereview.appspot.com/238540043

https://codereview.appspot.com/238540043/