Merge lp://qastaging/~frankban/juju-quickstart/jujubundlelib into lp://qastaging/juju-quickstart

Proposed by Francesco Banconi
Status: Merged
Merged at revision: 125
Proposed branch: lp://qastaging/~frankban/juju-quickstart/jujubundlelib
Merge into: lp://qastaging/juju-quickstart
Diff against target: 908 lines (+27/-639)
13 files modified
quickstart/app.py (+1/-1)
quickstart/charmstore.py (+3/-3)
quickstart/jujutools.py (+5/-4)
quickstart/manage.py (+2/-1)
quickstart/models/bundles.py (+4/-3)
quickstart/models/references.py (+0/-215)
quickstart/tests/models/test_bundles.py (+2/-4)
quickstart/tests/models/test_references.py (+0/-400)
quickstart/tests/test_app.py (+2/-4)
quickstart/tests/test_charmstore.py (+2/-2)
quickstart/tests/test_jujutools.py (+1/-1)
quickstart/tests/test_manage.py (+1/-1)
tox.ini (+4/-0)
To merge this branch: bzr merge lp://qastaging/~frankban/juju-quickstart/jujubundlelib
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+256906@code.qastaging.launchpad.net

Description of the change

Introduce jujubundlelib dependency.

Use the Reference model defined there.

https://codereview.appspot.com/228460043/

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+256906_code.launchpad.net,

Message:
Please take a look.

Description:
Introduce jujubundlelib dependency.

Use the Reference model defined there.

https://code.launchpad.net/~frankban/juju-quickstart/jujubundlelib/+merge/256906

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/228460043/

Affected files (+29, -639 lines):
   A [revision details]
   M quickstart/app.py
   M quickstart/charmstore.py
   M quickstart/jujutools.py
   M quickstart/manage.py
   M quickstart/models/bundles.py
   D quickstart/models/references.py
   M quickstart/tests/models/test_bundles.py
   D quickstart/tests/models/test_references.py
   M quickstart/tests/test_app.py
   M quickstart/tests/test_charmstore.py
   M quickstart/tests/test_jujutools.py
   M quickstart/tests/test_manage.py
   M tox.ini

Revision history for this message
Madison Scott-Clary (makyo) wrote :

LGTM, thanks for the work - we'll need to update tox.ini with versions
as tasks shake out from jujubundlelib, but that's fine.

https://codereview.appspot.com/228460043/

Revision history for this message
Francesco Banconi (frankban) wrote :

On 2015/04/22 15:34:12, matthew.scott wrote:
> LGTM, thanks for the work - we'll need to update tox.ini with versions
as tasks
> shake out from jujubundlelib, but that's fine.

Indeed, I'll update the bundlelib version in follow up branches.
Thanks for the review Madison!

https://codereview.appspot.com/228460043/

Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Introduce jujubundlelib dependency.

Use the Reference model defined there.

R=matthew.scott
CC=
https://codereview.appspot.com/228460043

https://codereview.appspot.com/228460043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches