juju-quickstart

Merge lp://qastaging/~frankban/juju-quickstart/lbox-requiring-sudo into lp://qastaging/juju-quickstart

lbox-requiring-sudo
Merge into trunk

Proposed by Francesco Banconi on 2015-02-09

Status:	Merged
Merged at revision:	119
Proposed branch:	lp://qastaging/~frankban/juju-quickstart/lbox-requiring-sudo
Merge into:	lp://qastaging/juju-quickstart
Diff against target:	59 lines (+7/-4) 5 files modified .lbox.check (+3/-0) Makefile (+1/-1) quickstart/app.py (+1/-1) quickstart/tests/models/test_envs.py (+1/-1) tox.ini (+1/-1)
To merge this branch:	bzr merge lp://qastaging/~frankban/juju-quickstart/lbox-requiring-sudo
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Juju GUI Hackers		2015-02-09	Pending
Review via email: mp+249047@code.qastaging.launchpad.net

Description of the change

Avoid requiring sudo privileges on lbox submit.

https://codereview.appspot.com/199470043/

Revision history for this message

Francesco Banconi (frankban) wrote on 2015-02-09:

Reviewers: mp+249047_code.launchpad.net,

Message:
Please take a look.

Description:
Avoid requiring sudo privileges on lbox submit.

https://code.launchpad.net/~frankban/juju-quickstart/lbox-requiring-sudo/+merge/249047

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/199470043/

Affected files (+5, -0 lines):
M .lbox.check
A [revision details]

Index: .lbox.check
=== modified file '.lbox.check'
--- .lbox.check 2013-10-14 11:43:06 +0000
+++ .lbox.check 2015-02-09 10:19:10 +0000
@@ -1,3 +1,6 @@
#!/bin/sh

+# Avoid requiring sudo privileges to install system dependencies.
+touch .sysdeps-installed
+# Run all the unit tests.
make check

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision:
<email address hidden>
+New revision:
<email address hidden>