Merge lp://qastaging/~frankban/juju-quickstart/local-osx into lp://qastaging/juju-quickstart

Proposed by Francesco Banconi
Status: Merged
Merged at revision: 82
Proposed branch: lp://qastaging/~frankban/juju-quickstart/local-osx
Merge into: lp://qastaging/juju-quickstart
Diff against target: 301 lines (+114/-22)
6 files modified
quickstart/cli/views.py (+35/-11)
quickstart/manage.py (+1/-1)
quickstart/models/envs.py (+6/-2)
quickstart/tests/cli/test_views.py (+55/-5)
quickstart/tests/models/test_envs.py (+16/-2)
quickstart/tests/test_manage.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~frankban/juju-quickstart/local-osx
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+223220@code.qastaging.launchpad.net

Description of the change

Avoid proposing LXC envs as an option on MacOS.

https://codereview.appspot.com/105250043/

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+223220_code.launchpad.net,

Message:
Please take a look.

Description:
Avoid proposing LXC envs as an option on MacOS.

https://code.launchpad.net/~frankban/juju-quickstart/local-osx/+merge/223220

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/105250043/

Affected files (+116, -22 lines):
   A [revision details]
   M quickstart/cli/views.py
   M quickstart/manage.py
   M quickstart/models/envs.py
   M quickstart/tests/cli/test_views.py
   M quickstart/tests/models/test_envs.py
   M quickstart/tests/test_manage.py

Revision history for this message
Brad Crittenden (bac) wrote :

LGTM with some typo fixes and QA-ok. Thanks Francesco.

https://codereview.appspot.com/105250043/diff/1/quickstart/tests/cli/test_views.py
File quickstart/tests/cli/test_views.py (right):

https://codereview.appspot.com/105250043/diff/1/quickstart/tests/cli/test_views.py#newcode42
quickstart/tests/cli/test_views.py:42: The value arguments is a boolean
representing whether or not local
typo: s/arguments/argument/

https://codereview.appspot.com/105250043/diff/1/quickstart/tests/cli/test_views.py#newcode186
quickstart/tests/cli/test_views.py:186: # The option to create a new
local environments is not present if they
typo: s/environments/environment/

https://codereview.appspot.com/105250043/

90. By Francesco Banconi

Fix typos.

Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Avoid proposing LXC envs as an option on MacOS.

R=bac
CC=
https://codereview.appspot.com/105250043

https://codereview.appspot.com/105250043/diff/1/quickstart/tests/cli/test_views.py
File quickstart/tests/cli/test_views.py (right):

https://codereview.appspot.com/105250043/diff/1/quickstart/tests/cli/test_views.py#newcode42
quickstart/tests/cli/test_views.py:42: The value arguments is a boolean
representing whether or not local
On 2014/06/16 12:27:11, bac wrote:
> typo: s/arguments/argument/

Done.

https://codereview.appspot.com/105250043/diff/1/quickstart/tests/cli/test_views.py#newcode186
quickstart/tests/cli/test_views.py:186: # The option to create a new
local environments is not present if they
On 2014/06/16 12:27:11, bac wrote:
> typo: s/environments/environment/

Done.

https://codereview.appspot.com/105250043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches