Merge lp://qastaging/~frankban/juju-quickstart/prepare-new-release into lp://qastaging/juju-quickstart

Proposed by Francesco Banconi
Status: Merged
Merged at revision: 54
Proposed branch: lp://qastaging/~frankban/juju-quickstart/prepare-new-release
Merge into: lp://qastaging/juju-quickstart
Diff against target: 354 lines (+96/-71)
9 files modified
HACKING.rst (+5/-0)
quickstart/__init__.py (+2/-2)
quickstart/app.py (+22/-2)
quickstart/manage.py (+2/-11)
quickstart/settings.py (+3/-3)
quickstart/tests/test_app.py (+52/-5)
quickstart/tests/test_manage.py (+8/-14)
quickstart/tests/test_utils.py (+1/-24)
quickstart/utils.py (+1/-10)
To merge this branch: bzr merge lp://qastaging/~frankban/juju-quickstart/prepare-new-release
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+207145@code.qastaging.launchpad.net

Description of the change

Minor changes in preparation for release.

Bump version up to 1.1.0.
Re-organize the "requires sudo" code.
Restore 100% unit test coverage (compulsive mode on).
Update license headers of modified files.

Tests: `make check`
QA: use quickstart as usual, bootstrapping
both ec2 and local environments.

https://codereview.appspot.com/65970043/

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+207145_code.launchpad.net,

Message:
Please take a look.

Description:
Minor changes in preparation for release.

Bump version up to 1.1.0.
Re-organize the "requires sudo" code.
Restore 100% unit test coverage (compulsive mode on).
Update license headers of modified files.

Tests: `make check`
QA: use quickstart as usual, bootstrapping
both ec2 and local environments.

https://code.launchpad.net/~frankban/juju-quickstart/prepare-new-release/+merge/207145

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/65970043/

Affected files (+93, -71 lines):
   A [revision details]
   M quickstart/__init__.py
   M quickstart/app.py
   M quickstart/manage.py
   M quickstart/settings.py
   M quickstart/tests/test_app.py
   M quickstart/tests/test_manage.py
   M quickstart/tests/test_utils.py
   M quickstart/utils.py

Revision history for this message
Richard Harding (rharding) wrote :

LGTM with the one note on potential room for a docs update.

Will QA.

https://codereview.appspot.com/65970043/diff/1/quickstart/manage.py
File quickstart/manage.py (right):

https://codereview.appspot.com/65970043/diff/1/quickstart/manage.py#newcode392
quickstart/manage.py:392: requires_sudo =
app.bootstrap_requires_sudo(is_local)
yay for functions that can be tested in isolation.

https://codereview.appspot.com/65970043/diff/1/quickstart/settings.py
File quickstart/settings.py (right):

https://codereview.appspot.com/65970043/diff/1/quickstart/settings.py#newcode35
quickstart/settings.py:35: JUJU_DEFAULT_SERIES = ('precise', 'quantal',
'raring', 'saucy', 'trusty')
good call, are these tweaks needed to keep it up to date noted? Maybe a
releases section in the hacking doc can note to check the latest charm
version and such?

https://codereview.appspot.com/65970043/

Revision history for this message
Richard Harding (rharding) wrote :
55. By Francesco Banconi

Changes as per review.

Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Minor changes in preparation for release.

Bump version up to 1.1.0.
Re-organize the "requires sudo" code.
Restore 100% unit test coverage (compulsive mode on).
Update license headers of modified files.

Tests: `make check`
QA: use quickstart as usual, bootstrapping
both ec2 and local environments.

R=rharding
CC=
https://codereview.appspot.com/65970043

https://codereview.appspot.com/65970043/diff/1/quickstart/settings.py
File quickstart/settings.py (right):

https://codereview.appspot.com/65970043/diff/1/quickstart/settings.py#newcode35
quickstart/settings.py:35: JUJU_DEFAULT_SERIES = ('precise', 'quantal',
'raring', 'saucy', 'trusty')
On 2014/02/19 13:29:09, rharding wrote:
> good call, are these tweaks needed to keep it up to date noted? Maybe
a releases
> section in the hacking doc can note to check the latest charm version
and such?

Done.

https://codereview.appspot.com/65970043/

Revision history for this message
Francesco Banconi (frankban) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches