Merge lp://qastaging/~frankban/juju-quickstart/support-old-series into lp://qastaging/juju-quickstart

Reviewers: mp+248150_code.launchpad.net,

Message:
Please take a look.

Description:
Enable tests for trusty and utopic.

Fix the unit test suite so that tests pass
when run in trusty and utopic scenarios.

Also add some simple functional tests. In those
tests, Quickstart is run against a real Juju env.

See the changes in the HACKING file for instructions
about running functional tests.

To QA this, run `make check` and `make fcheck`: the
latter can take some time.

https://code.launchpad.net/~frankban/juju-quickstart/support-old-series/+merge/248150

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/197240043/

Affected files (+265, -35 lines):
   M HACKING.rst
   M Makefile
   A [revision details]
   M quickstart/juju.py
   M quickstart/manage.py
   M quickstart/platform_support.py
   A quickstart/tests/functional/__init__.py
   A quickstart/tests/functional/test_functional.py
   M quickstart/tests/test_juju.py
   M setup.cfg
   M tox.ini

LGTM. No QA.

https://codereview.appspot.com/197240043/diff/1/quickstart/tests/functional/test_functional.py
File quickstart/tests/functional/test_functional.py (right):

https://codereview.appspot.com/197240043/diff/1/quickstart/tests/functional/test_functional.py#newcode87
quickstart/tests/functional/test_functional.py:87: cls.retcode,
cls.output, cls.error = run_quickstart(cls.env_name)
Thanks for the thoughtful test implementation.

It may be worth noting that run_quickstart only happens once per suite
not once per test as it isn't super obvious since we don't use
setUpClass all that much.

https://codereview.appspot.com/197240043/

Please take a look.

https://codereview.appspot.com/197240043/

LGTM Thanks for getting this working! I'll QA once we chat about my
comment.

https://codereview.appspot.com/197240043/diff/20001/quickstart/tests/functional/test_functional.py
File quickstart/tests/functional/test_functional.py (right):

https://codereview.appspot.com/197240043/diff/20001/quickstart/tests/functional/test_functional.py#newcode46
quickstart/tests/functional/test_functional.py:46: env_name =
envs.get_default_env_name()
As a precautionary measure I would prefer if there was a default
environment name for these tests. That way there would be no possible
way someone would accidentally run these tests on a live environment.

https://codereview.appspot.com/197240043/

QA OK Thanks for this branch!

https://codereview.appspot.com/197240043/

*** Submitted:

Enable tests for trusty and utopic.

Fix the unit test suite so that tests pass
when run in trusty and utopic scenarios.

Also add some simple functional tests. In those
tests, Quickstart is run against a real Juju env.

See the changes in the HACKING file for instructions
about running functional tests.

To QA this, run `make check` and `make fcheck`: the
latter can take some time.

R=bac, jeff.pihach
CC=
https://codereview.appspot.com/197240043

https://codereview.appspot.com/197240043/

Thanks for the reviews!

https://codereview.appspot.com/197240043/