Merge lp://qastaging/~frankban/juju-quickstart/views-params into lp://qastaging/juju-quickstart

Reviewers: mp+245753_code.launchpad.net,

Message:
Please take a look.

Description:
Refactor view parameters.

Implement a Params object used to store
common view parameters. This way it will
be easier to add parameters in the future
(e.g. one callable to remove stale jenv files).

New code include the params module and a fix
to the code handling the listing of jenv files
in the index view: now the header message is
only displayed if jenv files actually exist.

The rest of the diff is mechanical: i.e. replacing
the single view arguments with the params named
tuple.

Tests: `make check`.

QA:
Use the quickstart interactive session and
check everything works ok.

https://code.launchpad.net/~frankban/juju-quickstart/views-params/+merge/245753

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/194030043/

Affected files (+303, -172 lines):
   A [revision details]
   A quickstart/cli/params.py
   M quickstart/cli/views.py
   M quickstart/manage.py
   A quickstart/tests/cli/test_params.py
   M quickstart/tests/cli/test_views.py
   M quickstart/tests/test_manage.py

LGTM. No QA yet.

https://codereview.appspot.com/194030043/diff/1/quickstart/cli/views.py
File quickstart/cli/views.py (right):

https://codereview.appspot.com/194030043/diff/1/quickstart/cli/views.py#newcode314
quickstart/cli/views.py:314: # and supposed to be working/active. The
user has the ability to select
Maybe 'assumed' would be clearer than 'supposed'?

https://codereview.appspot.com/194030043/diff/1/quickstart/tests/cli/test_params.py
File quickstart/tests/cli/test_params.py (right):

https://codereview.appspot.com/194030043/diff/1/quickstart/tests/cli/test_params.py#newcode87
quickstart/tests/cli/test_params.py:87: self.assertNotEqual(self.params,
params)
Such a nice set of tests! Thanks for the clarity.

https://codereview.appspot.com/194030043/

LGTM

https://codereview.appspot.com/194030043/

QA-OK. I simply ran quickstart and launched a local provider.
Everything came up as expected.

https://codereview.appspot.com/194030043/

*** Submitted:

Refactor view parameters.

Implement a Params object used to store
common view parameters. This way it will
be easier to add parameters in the future
(e.g. one callable to remove stale jenv files).

New code include the params module and a fix
to the code handling the listing of jenv files
in the index view: now the header message is
only displayed if jenv files actually exist.

The rest of the diff is mechanical: i.e. replacing
the single view arguments with the params named
tuple.

Tests: `make check`.

QA:
Use the quickstart interactive session and
check everything works ok.

R=bac, martin.hilton
CC=
https://codereview.appspot.com/194030043

https://codereview.appspot.com/194030043/diff/1/quickstart/cli/views.py
File quickstart/cli/views.py (right):

https://codereview.appspot.com/194030043/diff/1/quickstart/cli/views.py#newcode314
quickstart/cli/views.py:314: # and supposed to be working/active. The
user has the ability to select
On 2015/01/07 15:58:26, bac wrote:
> Maybe 'assumed' would be clearer than 'supposed'?

Done.

https://codereview.appspot.com/194030043/

Thanks for the reviews!

https://codereview.appspot.com/194030043/