Merge lp://qastaging/~free.ekanayaka/landscape-client/mockify-package-taskhandler-tests into lp://qastaging/~landscape/landscape-client/trunk

Proposed by Free Ekanayaka
Status: Merged
Approved by: Free Ekanayaka
Approved revision: 844
Merged at revision: 875
Proposed branch: lp://qastaging/~free.ekanayaka/landscape-client/mockify-package-taskhandler-tests
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 447 lines (+115/-155)
1 file modified
landscape/package/tests/test_taskhandler.py (+115/-155)
To merge this branch: bzr merge lp://qastaging/~free.ekanayaka/landscape-client/mockify-package-taskhandler-tests
Reviewer Review Type Date Requested Status
Bogdana Vereha (community) Approve
Chris Glass (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+297555@code.qastaging.launchpad.net

Commit message

This. Is. Insane. Sorry.

Description of the change

This. Is. Insane. Sorry.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :
review: Approve (test results)
Revision history for this message
Chris Glass (tribaal) wrote :

+1, good job (that must have been pretty painful to write).

Just a small comment about more stuff you can drop (leftovers)

review: Approve
Revision history for this message
Bogdana Vereha (bogdana) wrote :

The biggest +1 ever (this was very painful). :)

In addition to tribaal's comments, I also added one related to some minor cleanup.

review: Approve
Revision history for this message
Free Ekanayaka (free.ekanayaka) :
844. By Free Ekanayaka

Address review comments

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: