Merge lp://qastaging/~freyes/charm-helpers/lp1670223 into lp://qastaging/charm-helpers
Proposed by
Felipe Reyes
Status: | Merged |
---|---|
Merged at revision: | 711 |
Proposed branch: | lp://qastaging/~freyes/charm-helpers/lp1670223 |
Merge into: | lp://qastaging/charm-helpers |
Diff against target: |
90 lines (+25/-5) 2 files modified
charmhelpers/contrib/charmsupport/nrpe.py (+5/-2) tests/contrib/charmsupport/test_nrpe.py (+20/-3) |
To merge this branch: | bzr merge lp://qastaging/~freyes/charm-helpers/lp1670223 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop (community) | Approve | ||
Ryan Beisner (community) | Needs Information | ||
Paul Gear (community) | Needs Information | ||
Review via email: mp+319207@code.qastaging.launchpad.net |
Description of the change
Verify if nagios user exists before attempting to run a check
There are cases where a charm may generate its configuration before
nagios-nrpe-server has been installed and attempting to run a check will
cause a failure due that /var/lib/nagios does not exist.
To post a comment you must log in.
@freyes, is there a reason you're gating this on the user existing rather than the directory existing? It seems to me that just ensuring the directory exists regardless of nagios- nrpe-server' s install state would be a more direct solution (assuming that's the only dependency between add_init_ service_ checks( ) and the nrpe package).