Merge lp://qastaging/~freyes/charms/trusty/glance-simplestreams-sync/lp1522929 into lp://qastaging/charms/trusty/glance-simplestreams-sync

Proposed by Felipe Reyes
Status: Merged
Merged at revision: 60
Proposed branch: lp://qastaging/~freyes/charms/trusty/glance-simplestreams-sync/lp1522929
Merge into: lp://qastaging/charms/trusty/glance-simplestreams-sync
Diff against target: 12 lines (+0/-2)
1 file modified
hooks/hooks.py (+0/-2)
To merge this branch: bzr merge lp://qastaging/~freyes/charms/trusty/glance-simplestreams-sync/lp1522929
Reviewer Review Type Date Requested Status
Mike McCracken (community) Approve
Edward Hope-Morley Approve
Review via email: mp+279644@code.qastaging.launchpad.net

Description of the change

Dear Maintainers,

This patch removed the addition of ppa:cloud-installer/simplestreams-testing during the install hook, that PPA contains a buggy version of simplestreams, the trusty version has a few security fixes applied and one patch to make it work ceph-radosgw

Best,

To post a comment you must log in.
Revision history for this message
Mike McCracken (mikemc) wrote :

Please hold off on merging this until we can resolve the problem that the version of simplestreams in Trusty does not support functionality needed by the cloud installer.

If this is urgently blocking you, I can offer to update the PPA to a current version of simplestreams that fixes LP #1346935.

Revision history for this message
Edward Hope-Morley (hopem) wrote :

@mikemc Charms should not install PPAs (some people are doing offline installs and want to control apt/image sources without interference from the charm). If this is absolutely necessary then it should at least be an option e.g. the ceph charm allows an alternate source to be installed with the 'source' option.

review: Approve
Revision history for this message
Mike McCracken (mikemc) wrote :

@hopem, that sounds like a good approach.
Let's merge this branch now and we can add the option and use that to fix the cloud installer afterwards.

review: Approve
Revision history for this message
Felipe Reyes (freyes) wrote :

Submitted another MP that targets /next[0], probably that one should be merged first.

https://code.launchpad.net/~freyes/charms/trusty/glance-simplestreams-sync/lp1522929-next/+merge/282958

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches