Juju Charms Collection
rsyslog package

Merge lp://qastaging/~freyes/charms/xenial/rsyslog/lp1694270 into lp://qastaging/~bigdata-dev/charms/xenial/rsyslog/trunk

  1. Xenial Xerus (16.04)
  2. lp1694270
  3. Merge into trunk
Proposed by Felipe Reyes
Status: Needs review
Proposed branch: lp://qastaging/~freyes/charms/xenial/rsyslog/lp1694270
Merge into: lp://qastaging/~bigdata-dev/charms/xenial/rsyslog/trunk
Diff against target: 1728 lines (+1013/-147)
17 files modified
hooks/charmhelpers/__init__.py (+61/-0)
hooks/charmhelpers/contrib/charmsupport/nrpe.py (+29/-10)
hooks/charmhelpers/core/hookenv.py (+47/-0)
hooks/charmhelpers/core/host.py (+225/-35)
hooks/charmhelpers/core/host_factory/centos.py (+16/-0)
hooks/charmhelpers/core/host_factory/ubuntu.py (+33/-0)
hooks/charmhelpers/core/kernel_factory/ubuntu.py (+1/-1)
hooks/charmhelpers/core/strutils.py (+53/-0)
hooks/charmhelpers/fetch/__init__.py (+17/-9)
hooks/charmhelpers/fetch/centos.py (+1/-1)
hooks/charmhelpers/fetch/snap.py (+122/-0)
hooks/charmhelpers/fetch/ubuntu.py (+314/-82)
hooks/charmhelpers/osplatform.py (+6/-0)
hooks/hooks.py (+8/-0)
templates/rsyslog.conf (+13/-0)
tox.ini (+1/-1)
unit_tests/test_hooks.py (+66/-8)
To merge this branch: bzr merge lp://qastaging/~freyes/charms/xenial/rsyslog/lp1694270
Reviewer Review Type Date Requested Status
Jorge Niedbalski Pending
Juju Big Data Development Pending
Review via email: mp+325877@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2017-05-29.

Description of the change

Use 'rotate' action from /etc/init.d/rsyslog

'reload' command does not exist in Xenial, the rsyslog package uses the
'rotate' functionality implemented in the sysvinit script to close all
open file descriptors.

To post a comment you must log in.
Revision history for this message
Jorge Niedbalski (niedbalski) wrote : Posted in a previous version of this proposal

Felipe,

I'd like to backport this change into trusty series, please make sure
to make this change back compatible from xenial.

<freyes> # invoke-rc.d rsyslog rotate
<freyes> initctl: invalid command: rotate

I will set it to needs fixing for now.

Thanks.

review: Needs Fixing
Revision history for this message
Felipe Reyes (freyes) wrote : Posted in a previous version of this proposal

Jorge,

Pushed some changes to address trusty. http://pastebin.ubuntu.com/24707222/

Now this patch uses CompareHostsReleases() to decide which command to use after log rotation.

Thanks

Unmerged revisions

40. By Felipe Reyes

Remove print() statement left from testing

39. By Felipe Reyes

Use invoke-rc.d only for >=Xenial and add unit tests

38. By Felipe Reyes

Add py27 to tox

This will prevent regressions with python2.7 needed to run in trusty

37. By Felipe Reyes

Sync up charm-helpers

36. By Felipe Reyes

Replace space indentation with tab

35. By Felipe Reyes

Use 'rotate' action from /etc/init.d/rsyslog

'reload' command does not exist in Xenial, the rsyslog package uses the
'rotate' functionality implemented in the sysvinit script to close all
open file descriptors.

Closes-Bug: 1694270

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches