Merge lp://qastaging/~freyes/maas-deployer/lp1570218 into lp://qastaging/~maas-deployers/maas-deployer/next

Proposed by Felipe Reyes
Status: Merged
Merged at revision: 77
Proposed branch: lp://qastaging/~freyes/maas-deployer/lp1570218
Merge into: lp://qastaging/~maas-deployers/maas-deployer/next
Diff against target: 276 lines (+81/-33)
6 files modified
examples/deployment.yaml (+2/-2)
maas_deployer/tests/test_vm.py (+51/-6)
maas_deployer/vmaas/engine.py (+1/-1)
maas_deployer/vmaas/templates/cloud-init.cfg (+1/-1)
maas_deployer/vmaas/util.py (+3/-2)
maas_deployer/vmaas/vm.py (+23/-21)
To merge this branch: bzr merge lp://qastaging/~freyes/maas-deployer/lp1570218
Reviewer Review Type Date Requested Status
Billy Olsen Approve
Edward Hope-Morley Needs Fixing
Review via email: mp+301726@code.qastaging.launchpad.net

Description of the change

Split 'arch' into 'build_arch' and 'kernel_arch'

This allows to make a clear differentiation what's the expected 'arch'
in libvirt (kernel arch) versus the 'arch' expected by MAAS (build arch).

So users can define the arch in deployment.yaml as 'ppc64el' or 'pp64' and get a functional deployment, as the juju/maas vms will be launched using 'ppc64' and using the ubuntu ppc64el cloud image.

To post a comment you must log in.
79. By Felipe Reyes

Mock virsh

Revision history for this message
Felipe Reyes (freyes) wrote :

A user with access to a power8 machine is testing this patch (available at https://launchpad.net/~freyes/+archive/ubuntu/lp1570218 )

Revision history for this message
Edward Hope-Morley (hopem) :
review: Needs Fixing
Revision history for this message
Felipe Reyes (freyes) :
80. By Felipe Reyes

Fix command line parsing

Revision history for this message
Felipe Reyes (freyes) wrote :
Revision history for this message
Billy Olsen (billy-olsen) wrote :

LGTM, thanks Felipe!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches