Merge lp://qastaging/~gala-dev/gala/no-show-overlap into lp://qastaging/gala
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~gala-dev/gala/no-show-overlap |
| Merge into: | lp://qastaging/gala |
| Diff against target: |
241 lines (+66/-43) 4 files modified
src/Plugin.vala (+49/-1) src/Widgets/WindowOverview.vala (+6/-11) src/Widgets/WindowSwitcher.vala (+5/-25) src/Widgets/WindowThumb.vala (+6/-6) |
| To merge this branch: | bzr merge lp://qastaging/~gala-dev/gala/no-show-overlap |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Rico Tzschichholz | Needs Fixing | ||
| Cody Garver (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Looking for testers for this branch.
Expected results: you will never get windows showing in the background while alt-tabbing or opening the windowoverview (should have mainly happened when you're very quick)
Possible problems: windows still showing while having those open, windows not showing again
This introduces a new visible_count on plugin with two new methods request_show and request_hide on the plugin which are being called with or shortly after, when the animation ends, the begin_- and end_modal methods of plugin to make sure that no show loop overrides a previous hiding loop from a different modal actor.
I'm not entirely sure whether I catched all the places where a show had to be removed or whether I removed on too much, so please have this tested for a bit.
| Cody Garver (codygarver) wrote | # |
Unmerged revisions
- 351. By Tom Beckmann
-
and one more whitespace cleaned
- 350. By Tom Beckmann
-
cleanup some whitespaces
- 349. By Tom Beckmann
-
fix flickering in windowoverview
- 348. By Tom Beckmann
-
remove unnecessary hide class
- 347. By Tom Beckmann
-
fix workspaceswitching, cleanup
- 346. By Tom Beckmann
-
Add a visible_count property which makes sure windows are only shown when there are no modal states active
My issues with this branch have been resolved and have not seen any new problems.