Juju Charms Collection
nova-cloud-controller package

Merge lp://qastaging/~gandelman-a/charms/precise/nova-cloud-controller/live_migration into lp://qastaging/~charmers/charms/precise/nova-cloud-controller/trunk

  1. Precise Pangolin (12.04)
  2. live_migration
  3. Merge into trunk
Proposed by Adam Gandelman
Status: Rejected
Rejected by: Adam Gandelman
Proposed branch: lp://qastaging/~gandelman-a/charms/precise/nova-cloud-controller/live_migration
Merge into: lp://qastaging/~charmers/charms/precise/nova-cloud-controller/trunk
Diff against target: 819 lines (+493/-85)
9 files modified
config.yaml (+0/-4)
hooks/lib/nova/essex (+2/-2)
hooks/lib/nova/folsom (+3/-5)
hooks/lib/nova/grizzly (+80/-0)
hooks/lib/nova/nova-common (+27/-2)
hooks/lib/openstack-common (+136/-22)
hooks/nova-cloud-controller-common (+190/-35)
hooks/nova-cloud-controller-relations (+54/-14)
revision (+1/-1)
To merge this branch: bzr merge lp://qastaging/~gandelman-a/charms/precise/nova-cloud-controller/live_migration
Reviewer Review Type Date Requested Status
James Page Needs Fixing
Review via email: mp+142431@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Adam Gandelman (gandelman-a) wrote :

This adds grizzly support and makes nova-c-c the coordinator of ssh key access for compute nodes, for purposes of live migration.

Revision history for this message
James Page (james-page) wrote :

Hi Adam

First pass feedback

1) General approach to key distribution

Why use an HTTP server for distribution of keys and authorized hosts? This data could be passed using juju using bas64 encode/decode. That way if multiple cloud-controller instances are running the data transfer is simpler as data is always passed via juju rather than being retrieved from XX server.

2) QUANTUM_* variables

I hit a few issues testing this update with Quantum; most of the quantum functions rely on the QUANTUM_* variables being set every hook execution but the changes in nova-cloud-controller-common change this; as a result the initial configuration of quantum in hooks/lib/nova/nova-common fails as the PLUGIN is not set and configure_quantum_networking has a similar issue. Needs a bit more work.

review: Needs Fixing
lp://qastaging/~gandelman-a/charms/precise/nova-cloud-controller/live_migration updated
56. By Adam Gandelman

Actually use determine_quantum_config when needed.

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

James-

Thanks. I've updated the branch to address the second issue. There was existing functions set to deal with that issue, but they were not being called when needed.

Regarding key distribution, I've been hesitant to use the juju environment as a dumping ground for files but in this case I think you're right. Even with many compute nodes, the files / base64 encodings won't grow too big. I hadn't thought of the issue of multiple nova-c-c's but again you are right. It does complicate things and the current method would require some fixing to avoid nova-compute wget'ing the files from every nova-c-c node. I'll give the base64 method a shot and update the branch if it works out.

lp://qastaging/~gandelman-a/charms/precise/nova-cloud-controller/live_migration updated
57. By Adam Gandelman

Replace WWW key distribution in favor of base64 encoded relation settings.

58. By Adam Gandelman

openstack-common: Update for Grizzly (and beyond) access via U.C.A.

59. By Adam Gandelman

Sync openstack-common.

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

Closing this out. Rebased and redirected this work against other WIP charm branches:

https://code.launchpad.net/~gandelman-a/charms/precise/nova-cloud-controller/openstack-charmers-merge/+merge/143801

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches