camera-app

Merge lp://qastaging/~gang65/camera-app/camera-app-reduce-png-svg-size into lp://qastaging/camera-app

  1. camera-app-reduce-png-svg-size
  2. Merge into trunk
Proposed by Bartosz Kosiorek
Status: Merged
Approved by: Florian Boucault
Approved revision: 590
Merged at revision: 601
Proposed branch: lp://qastaging/~gang65/camera-app/camera-app-reduce-png-svg-size
Merge into: lp://qastaging/camera-app
Diff against target: 439 lines (+49/-350)
2 files modified
assets/grid_lines.svg (+25/-177)
assets/self_timer.svg (+24/-173)
To merge this branch: bzr merge lp://qastaging/~gang65/camera-app/camera-app-reduce-png-svg-size
Reviewer Review Type Date Requested Status
Bartosz Kosiorek (community) Needs Information
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+276340@code.qastaging.launchpad.net

Commit message

Improve camera performance by optimized size of the png and svg files,
without changing visual appearance (used compresspng.com and compressor.io)

Description of the change

Improve camera performance by optimized size of the png and svg files,
without changing visual appearance (used compresspng.com and compressor.io)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:590
http://jenkins.qa.ubuntu.com/job/camera-app-ci/446/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/142/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/142/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/142/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/291
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/947
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/776
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24772

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/446/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Jenkins have following error:

"Ubuntu.Components" version 1.3 is not installed
     import Ubuntu.Components 1.3

How it is possible to install new SDK?

review: Needs Information
Revision history for this message
Sebastien Bacher (seb128) wrote :

The current codebase is on 1.3 so a CI retry should work. Do you have numbers on what difference that change is doing?

Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Reducing size of png/svg images, decrease images load times.
I already pushed similar optimization to Clock and results were as follows:

Not optimized PNG files:
QtQuick/Loader Background: 2.554ms
QtQuick/Image Inner Clock: 4.921ms

Optimized PNG files:
QtQuick/Loader Background: 1,246ms
QtQuick/Image Inner Clock: 2.347ms

More information is available at:
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-reduce-image-size/+merge/270229

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches