Ubuntu Clock App

Merge lp://qastaging/~gang65/ubuntu-clock-app/ubuntu-clock-raplace-icon into lp://qastaging/ubuntu-clock-app

  1. ubuntu-clock-raplace-icon
  2. Merge into trunk
Proposed by Bartosz Kosiorek
Status: Merged
Approved by: Bartosz Kosiorek
Approved revision: 306
Merged at revision: 306
Proposed branch: lp://qastaging/~gang65/ubuntu-clock-app/ubuntu-clock-raplace-icon
Merge into: lp://qastaging/ubuntu-clock-app
Diff against target: 31 lines (+4/-3)
2 files modified
app/clock/ClockPage.qml (+3/-3)
debian/changelog (+1/-0)
To merge this branch: bzr merge lp://qastaging/~gang65/ubuntu-clock-app/ubuntu-clock-raplace-icon
Reviewer Review Type Date Requested Status
Nekhelesh Ramananthan code review Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+265384@code.qastaging.launchpad.net

Commit message

Replace location icon with default Suru (LP: #1476580)

Description of the change

Replace location icon with default Suru (LP: #1476580)

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:306
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/696/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3116/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/696/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:306
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/697/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/42
        deb: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/42/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/697/rebuild

review: Approve (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Code lgtm!

review: Approve (code review)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Bartosz, not sure why jenkins reverted, but I had CI fix as you can see. Not sure if you ever got my messages via IRC :p

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches