Merge lp://qastaging/~gary-lasker/software-center/launcher-integration-for-p into lp://qastaging/software-center

Proposed by Gary Lasker
Status: Merged
Merged at revision: 2575
Proposed branch: lp://qastaging/~gary-lasker/software-center/launcher-integration-for-p
Merge into: lp://qastaging/software-center
Diff against target: 748 lines (+266/-243)
6 files modified
data/ui/gtk3/SoftwareCenter.ui (+20/-4)
softwarecenter/backend/unitylauncher.py (+98/-0)
softwarecenter/ui/gtk3/app.py (+35/-4)
softwarecenter/ui/gtk3/panes/availablepane.py (+91/-2)
softwarecenter/ui/gtk3/panes/softwarepane.py (+2/-193)
test/gtk3/test_unity_launcher_integration.py (+20/-40)
To merge this branch: bzr merge lp://qastaging/~gary-lasker/software-center/launcher-integration-for-p
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+83953@code.qastaging.launchpad.net

Description of the change

This branch implements the Software Center side of mpt's updated design for launcher integration functionality for Precise (https://wiki.ubuntu.com/SoftwareCenter#Learning_how_to_launch_an_application). It removes the explicit slide-in prompt in the details view for adding an item to the launcher, and instead always adds the item (or not) depending on the state of the new menu item "View->Add Applications in Launcher". A nice side-effect of the new design is that it now supports adding items to the launcher when they are installed from the details view.

There is also some refactoring to clean things up a bit and to set the stage for an easy update when the full Unity side implementation is ready. There's a new UnityLauncher class and you'll notice that I migrated the UI-side launcher integration code out of SoftwarePane and down into AvailablePane (there's no longer a reason for it to be in the superclass since we no longer use the ChannelPane).

The current implementation in the branch is designed to work using the Unity launcher dbus capabilities as they exist now. As such, it adds the application to the launcher once it has been installed, and does not yet display the install progress in the launcher. That functionality will come after the Unity side implementation is completed.

Finally, the supporting unit tests are updated and working.

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Btw, the code in availablepane simplifies *a lot* once we get the full Unity implementation. Most of that code is just to queue up simultaneous installs to be able to do the desktop file and icon location updates as required for the current Unity dbus implementation.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches