Merge lp://qastaging/~gary-lasker/software-center/previous-purchase-sorting-lp873104 into lp://qastaging/software-center/5.2
Proposed by
Gary Lasker
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Merged at revision: | 3049 | ||||||||
| Proposed branch: | lp://qastaging/~gary-lasker/software-center/previous-purchase-sorting-lp873104 | ||||||||
| Merge into: | lp://qastaging/software-center/5.2 | ||||||||
| Diff against target: |
83 lines (+11/-7) 3 files modified
softwarecenter/backend/channel.py (+2/-0) softwarecenter/ui/gtk3/panes/availablepane.py (+9/-5) softwarecenter/ui/gtk3/panes/softwarepane.py (+0/-2) |
||||||||
| To merge this branch: | bzr merge lp://qastaging/~gary-lasker/software-center/previous-purchase-sorting-lp873104 | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Vogt (community) | Approve | ||
|
Review via email:
|
|||
Commit message
* lp:~gary-lasker/software-center/previous-purchase-sorting-lp873104:
- return correct results when sorting the list of previous
purchases (LP: #873104)
- fix bug that caused a search of the list of previous purchases to
return too many items (LP: #969273)
Description of the change
This branch fixes bug 873104 and bug 969273 by replacing the "special case" code for the previous purchases view with in an implementation using a SoftwareChannel. This allows us to use the view state in the way that we do for the other available pane views, and thereby fixes the two issues described by these bug reports.
Please also note that I removed the unused 'previous_
All unit tests pass.
Many thanks for your review!
To post a comment you must log in.
Revision history for this message
| Michael Vogt (mvo) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for your branch.
This is great work and a nice improvement, especially that the special case got removed is great.
The change:
29 + self.state.
make me a little bit nervous as the _clear_search() is called in various places, but I could not
think of (or find one by playing around) any regression this might cause so I think its fine.
Unfortunately bug #969273 is only fixed inside the "Previous purchases" subcategory (which is nice),
but its not fixed in the "All software" case which Michael Terry was referring to in the bugreport.
I updated the description there to make the testcase clearer. For me it still returns
three items with this branch. But that is not a regression or anything like this, so I'm happy to
merge the branch as #873104 is fixed.