Merge lp://qastaging/~gary-wzl77/news-scope/fat_click_package into lp://qastaging/news-scope

Proposed by Gary.Wang
Status: Needs review
Proposed branch: lp://qastaging/~gary-wzl77/news-scope/fat_click_package
Merge into: lp://qastaging/news-scope
Diff against target: 67 lines (+13/-4)
2 files modified
make-click.sh (+11/-2)
manifest.json (+2/-2)
To merge this branch: bzr merge lp://qastaging/~gary-wzl77/news-scope/fat_click_package
Reviewer Review Type Date Requested Status
news-scope-team Pending
Review via email: mp+301150@code.qastaging.launchpad.net

Commit message

generate fat click package when building.

Description of the change

generate fat click package when building.

To post a comment you must log in.
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hey Gary,

I think that because you are doing this same type of "fat package" change to all branches and because you are testing them and you are the expert in this area, you should go ahead commit to trunks with merge proposals (unless there is a special case you want to bring to attention).

Also, I wonder what the overall plan is:
* is a single click package intended to contain the .so files for all architectures?
* or will there be a click package differentiated by file name including the arch for each arch?

Can you please explain this.

Cheers

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

I meant to say "commit to trunk WITHOUT merge proposals" (oops ;)

Revision history for this message
Gary.Wang (gary-wzl77) wrote :

Hi Kyle
Thanks for your question.

* is a single click package intended to contain the .so files for all architectures?
A: Yes, you're right, there's a single click package generated in following name convention after running make_click.sh
   ${PKG}_${SCOPE_NAME}_${VER_NUM}_multi.click
   the trailing string "_multi" indicates this click package contains binary files for all architectures which are declared in manifest.json.in
   ...
   "architecture": ["armhf", "arm64", "i386", "amd64"],
   ...

   As you can see, I added aggregator library(arm64) into a new folder(click-src/aggregator/aarch64-linux-gnu) and moved original armhf binary file into arm-linux-gnueabihf. That allows scope shell to load right binary file according to host architecture.
End user is able to install a single click package to all platform as long as the corresponding binary file can be found for each architecture.
This's how we support multi-architectures for all aggregator scope.

For each stand-alone scope, it's a little bit different.
I deploy a new script(build_fat_click.sh) for each scope.
https://bazaar.launchpad.net/~hanloon-team/hanloon/timeout/revision/52
you can use this script to generate fat click package as long as the declared architectures are created in your chroot.

P.S. You can still use previous way to generate armhf click. It's fine.
     Question: which kind of click we need to create and release on the store in the future, armhf or multi? Personally, I'd tend to the latter. Let's discuss with team members on this.

Unmerged revisions

59. By Gary.Wang

generate fat click package when building.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: