Ubuntu Calendar App

Merge lp://qastaging/~gary-wzl77/ubuntu-calendar-app/fix-1472081 into lp://qastaging/ubuntu-calendar-app

  1. fix-1472081
  2. Merge into trunk
Proposed by Gary.Wang
Status: Merged
Approved by: Mihir Soni
Approved revision: 692
Merged at revision: 703
Proposed branch: lp://qastaging/~gary-wzl77/ubuntu-calendar-app/fix-1472081
Merge into: lp://qastaging/ubuntu-calendar-app
Diff against target: 233 lines (+41/-32)
4 files modified
EventDetails.qml (+4/-2)
NewEvent.qml (+7/-4)
TimeLineBase.qml (+6/-2)
po/com.ubuntu.calendar.pot (+24/-24)
To merge this branch: bzr merge lp://qastaging/~gary-wzl77/ubuntu-calendar-app/fix-1472081
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+264152@code.qastaging.launchpad.net

Commit message

1.fix display bug for multiple all day events
2.skip event bubble display in case of endDateTime == dd-MM-yyyy 12:00 AM

Description of the change

1.fix display bug for multiple all day events
2.skip event bubble display in case of endDateTime == dd-MM-yyyy 12:00 AM

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:692
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1208/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3050
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3050/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/679
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/205

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1208/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Looks good to me, thanks!

review: Approve
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me !!
Could you please make sure when you commit next time , you revert the pot Files manually ?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: