Merge lp://qastaging/~gary-wzl77/ubuntu-system-settings-online-accounts/OAtuh-userAgent into lp://qastaging/ubuntu-system-settings-online-accounts

Proposed by Gary.Wang
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 384
Merged at revision: 385
Proposed branch: lp://qastaging/~gary-wzl77/ubuntu-system-settings-online-accounts/OAtuh-userAgent
Merge into: lp://qastaging/ubuntu-system-settings-online-accounts
Diff against target: 41 lines (+5/-1)
2 files modified
plugins/module/OAuth.qml (+3/-1)
plugins/module/WebView.qml (+2/-0)
To merge this branch: bzr merge lp://qastaging/~gary-wzl77/ubuntu-system-settings-online-accounts/OAtuh-userAgent
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
Review via email: mp+304212@code.qastaging.launchpad.net

Commit message

add a new property "userAgent" for OAuth item.

Description of the change

add a new property "userAgent" for OAuth item.

To post a comment you must log in.
Revision history for this message
Alberto Mardegan (mardy) wrote :

Thanks Gary! Mostly good, just please have a look at the inline comments.

review: Needs Fixing
384. By Gary.Wang

code change according to inline comments.

Revision history for this message
Alberto Mardegan (mardy) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches