U1DB Qt/ QML

Merge lp://qastaging/~gcollura/u1db-qt/fix-1387294 into lp://qastaging/u1db-qt

  1. fix-1387294
  2. Merge into trunk
Proposed by Giulio Collura
Status: Needs review
Proposed branch: lp://qastaging/~gcollura/u1db-qt/fix-1387294
Merge into: lp://qastaging/u1db-qt
Diff against target: 32 lines (+12/-9)
1 file modified
src/database.cpp (+12/-9)
To merge this branch: bzr merge lp://qastaging/~gcollura/u1db-qt/fix-1387294
Reviewer Review Type Date Requested Status
Michał Karnicki Needs Information
Cris Dywan Needs Information
Review via email: mp+240035@code.qastaging.launchpad.net

Commit message

Make u1db-qt play nice with ~ as absolute directory.

Description of the change

Fix for bug #1387294. Make u1db-qt play nice with ~ as absolute directory.

To post a comment you must log in.
lp://qastaging/~gcollura/u1db-qt/fix-1387294 updated
121. By Giulio Collura

improve codestyle

Revision history for this message
Michał Karnicki (karni) wrote :

Looks good to me. Can we please have someone from U1DB Qt devs review and advise on how we get this landed? Thanks.

Reply
Revision history for this message
Cris Dywan (kalikiana) wrote :

My immediate concern is that this isn't addressing the use case it was motivated by - if settings stored in U1Db should go to the config folder, ~ is the wrong approach.

review: Needs Information
Reply
Revision history for this message
Giulio Collura (gcollura) wrote :

What would you suggest instead? We would like to have the chance to use .config for all data app. We can add another property to Database that stores the destination folder, for example:
Database {
  path: 'hello.db'
  location: Database.ConfigLocation
}
I'm not sure about the naming convention, the default option would be Database.DataLocation.
These would be values of an enum exported to qml.
Let me know what you think about this solution.

Giulio

Reply
Revision history for this message
Michał Karnicki (karni) wrote :

I have mixed feelings. Let's not forget U1DB can also be used by desktop apps, which currently are not confined and apparmor restrictions do not apply.

Reply
Revision history for this message
Michał Karnicki (karni) wrote :

Hi Christian,

Have you made decision how you want to proceed with this bug? Soon this will affect Telegram, where (IIUC) there no longer is 'phablet' user in the new image.

review: Needs Information
Reply

Unmerged revisions

121. By Giulio Collura

improve codestyle

120. By Giulio Collura

Fix bug #1387294. Improve database path creation.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: