Juju Charms Collection
stackmobile package

Merge lp://qastaging/~george-edison55/charms/precise/stackmobile/added-icon into lp://qastaging/charms/stackmobile

  1. Precise Pangolin (12.04)
  2. added-icon
  3. Merge into trunk
Proposed by Nathan Osman
Status: Merged
Merged at revision: 11
Proposed branch: lp://qastaging/~george-edison55/charms/precise/stackmobile/added-icon
Merge into: lp://qastaging/charms/stackmobile
Diff against target: 296 lines (+250/-8)
4 files modified
README.md (+6/-6)
config.yaml (+2/-2)
icon.svg (+240/-0)
metadata.yaml (+2/-0)
To merge this branch: bzr merge lp://qastaging/~george-edison55/charms/precise/stackmobile/added-icon
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Kevin W Monroe Needs Fixing
Review via email: mp+183274@code.qastaging.launchpad.net

Description of the change

I have made a couple of minor adjustments to this branch:

* added an icon
* switched from a plaintext README to Markdown

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Hi Nathan, thanks for submitting this. The icon you've provided doesn't fit our requirements for an icon in the charm store. You can find the instructions and template in the docs: https://juju.ubuntu.com/docs/authors-charm-icon.html You're essentially there just need to have the "default" background to match the other charm icons in store.

Other than that, the rewrite of the README looks great, thanks for you patience, sorry it's taken so long to get to this reviewed!

review: Needs Fixing
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Finally, when you need another review, just "Request another review" from "charmers" and we'll respond a lot quicker next time.

Revision history for this message
Nathan Osman (george-edison55) wrote :

I've fixed up the icon (thanks for linking to the docs). Where am I looking for this "Request another review" button? Are you referring to the charmers group on Launchpad?

Revision history for this message
Kevin W Monroe (kwmonroe) wrote :

Hi Nathan - we've recently updated our review queue process and noticed this fell through the cracks months ago. Apologies! Your icon/readme updates look great, but charm proof reports a missing 'categories:' option in metadata.yaml. See the categories section for more info:

https://juju.ubuntu.com/docs/authors-charm-writing.html

'miscellaneous' seems appropriate here. We've moved this back to Work in Progress. Once you've updated metadata.yaml, please move to Needs Review again - that will automatically put this back onto the review queue. Thanks for your patience here.

review: Needs Fixing
Revision history for this message
Nathan Osman (george-edison55) wrote :

I've set the category to "miscellaneous" now.

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: