unity-2d

Merge lp://qastaging/~gerboland/unity-2d/launcher-tweaks into lp://qastaging/unity-2d

launcher-tweaks
Merge into trunk

Proposed by Gerry Boland on 2012-02-20

Status:	Merged
Approved by:	Albert Astals Cid on 2012-02-24
Approved revision:	932
Merged at revision:	936
Proposed branch:	lp://qastaging/~gerboland/unity-2d/launcher-tweaks
Merge into:	lp://qastaging/unity-2d
Diff against target:	73 lines (+18/-2) 2 files modified shell/launcher/Launcher.qml (+17/-1) shell/launcher/LauncherList.qml (+1/-1)
To merge this branch:	bzr merge lp://qastaging/~gerboland/unity-2d/launcher-tweaks
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Albert Astals Cid (community)			Approve on 2012-02-24
Xi Zhu (community)	design	2012-02-24	Approve on 2012-02-24
Michał Sawicz			Needs Information on 2012-02-21
Andrea Cimitan		2012-02-21	Pending
Lohith D Shivamurthy		2012-02-20	Pending
Review via email: mp+93798@code.qastaging.launchpad.net

Description of the change

[launcher] Pixel-perfection changes: add glow-less assets, position tiles 6 pixels from screen edge, add white 15% opaque line as launcher border, and move activity pip to border this line. Context menu arrow overlaps activity pip.

Revision history for this message

Michał Sawicz (saviq) wrote on 2012-02-21:

Shouldn't we have a before / after screenshots here for design to sign off on?

review: Needs Information

Revision history for this message

Gerry Boland (gerboland) wrote on 2012-02-21:

Indeed I should have:
before: https://imgur.com/2OPel
after: https://imgur.com/wDIB0

Revision history for this message

Gerry Boland (gerboland) wrote on 2012-02-21:

And for the context menu:
before: https://imgur.com/a/ZZJQV
after: https://imgur.com/ga4az

Revision history for this message

Xi Zhu (xi.zhu) on 2012-02-24:

review: Approve (design)

lp://qastaging/~gerboland/unity-2d/launcher-tweaks updated on 2012-02-24

929. By Gerry Boland on 2012-02-24: Merge trunk

Revision history for this message

Albert Astals Cid (aacid) wrote on 2012-02-24:

In
anchors.rightMargin: declarativeView.dashActive ? 0 : 1
should that 1 be border.width?

I find it confusing to have one Item Accessible.name: "borderWithDash" and id: border and then a different Item with Accessible.name: "border" and no id, woulnd't it be better to name the second one "borderWithoutDash" and not change the first one?

In the second "border" i think it'd be better if you bind all the other properties to the "first" border, so if something changes we just need to change one, i.e.

anchors.right: border.anchors.right
anchors.left: border.anchors.left
visible: !border.visible

lp://qastaging/~gerboland/unity-2d/launcher-tweaks updated on 2012-02-24

930. By Gerry Boland on 2012-02-24: Use border.width instead of 1
931. By Gerry Boland on 2012-02-24: Border line & image share anchors
932. By Gerry Boland on 2012-02-24: Use better accessible name for border line

Revision history for this message

Gerry Boland (gerboland) wrote on 2012-02-24:

Ok, code-fixes made.

Revision history for this message

Albert Astals Cid (aacid) wrote on 2012-02-24:

I'll be more of a pain yet, i think m_arrowY value in LauncherContextualMenu::show should be set to 7 and not 6, otherwise the pip and the menu arrow do not totally overlap (Yes this nagged me the first time i saw it visually)

review: Needs Fixing

Revision history for this message

Albert Astals Cid (aacid) wrote on 2012-02-24:

Approving, the 7/6 thing is not something Gerry "broke" and actually while it looks better for me with a 7 it looks better for him with a 6, so future work

review: Approve