Merge lp://qastaging/~gerboland/unity-mir/appManV2-compat into lp://qastaging/unity-mir

Proposed by Gerry Boland
Status: Work in progress
Proposed branch: lp://qastaging/~gerboland/unity-mir/appManV2-compat
Merge into: lp://qastaging/unity-mir
Diff against target: 210 lines (+54/-13)
7 files modified
CMakeLists.txt (+1/-1)
debian/changelog (+6/-0)
debian/control (+3/-3)
src/modules/Unity/Application/application.cpp (+8/-1)
src/modules/Unity/Application/application.h (+3/-1)
src/modules/Unity/Application/application_manager.cpp (+21/-0)
src/modules/Unity/Application/application_manager.h (+12/-7)
To merge this branch: bzr merge lp://qastaging/~gerboland/unity-mir/appManV2-compat
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Needs Information
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+219407@code.qastaging.launchpad.net

Commit message

Update to use AppManagerV3 API. Bump package version to 1.1.0 to match library version

Description of the change

Update to use AppManagerV3 API

 * Are there any related MPs required for this MP to build/function as expected? Please list.
https://code.launchpad.net/~gerboland/unity-api/appManVersion2/+merge/219403
https://code.launchpad.net/~gerboland/unity8/appManV2-compat/+merge/219673
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Y

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

same here... I thought we were going to get rid of

bool requestFocusApplication(const QString &appId);

review: Needs Information
Revision history for this message
Gerry Boland (gerboland) wrote :

QtComp will get rid of requestFocusApplication, which is why I removed it from unity-api. But current shell still needs it.

This sequence of MRs is so that we can land the unity-api change separately and sooner, and qtcomp later.

This MR does not change any APIs, just ensures unity-mir builds against the updated unity-api.

Unmerged revisions

229. By Gerry Boland

debian: depend on unity-api version 7.90 or greater

228. By Gerry Boland

debian" bump to 1.1.0 to match library version

227. By Gerry Boland

Restore Application::screenshot and related APIs

226. By Gerry Boland

debian: libubuntu-app-launch2-dev build dependency restored

225. By Gerry Boland

debian package version to 0.5

224. By Gerry Boland

Merge trunk

223. By Gerry Boland

Debian/Control: libunity-mir1 provides unity-application-impl-3

222. By Gerry Boland

Bump library version and increase package version to match it

221. By Gerry Boland

Bump unity-api package dependency version

220. By Gerry Boland

Adopt to AppManV2 API defined in unity-api

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches