unity-mir

Merge lp://qastaging/~gerboland/unity-mir/listen-for-server-start-stop-ready into lp://qastaging/unity-mir

  1. listen-for-server-start-stop-ready
  2. Merge into trunk
Proposed by Gerry Boland
Status: Merged
Approved by: Michał Sawicz
Approved revision: 133
Merged at revision: 152
Proposed branch: lp://qastaging/~gerboland/unity-mir/listen-for-server-start-stop-ready
Merge into: lp://qastaging/unity-mir
Diff against target: 165 lines (+100/-2)
6 files modified
debian/changelog (+9/-0)
src/unity-mir/serverstatuslistener.cpp (+45/-0)
src/unity-mir/serverstatuslistener.h (+30/-0)
src/unity-mir/shellserverconfiguration.cpp (+11/-0)
src/unity-mir/shellserverconfiguration.h (+1/-0)
src/unity-mir/unity-mir.pro (+4/-2)
To merge this branch: bzr merge lp://qastaging/~gerboland/unity-mir/listen-for-server-start-stop-ready
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michael Zanetti (community) Approve
Alan Griffiths Approve
Review via email: mp+196269@code.qastaging.launchpad.net

Commit message

Install ServerStatusListener to be notified of mir server start, pause and resume.

Use start notification to send SIGSTOP signal to upstart, so it knows mir is ready for other clients

Description of the change

Install ServerStatusListener to be notified of mir server start, pause and resume.

Use start notification to send SIGSTOP signal to upstart, so it knows mir is ready for other clients

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:131
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/161/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/22
        deb: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/22/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-i386-ci/22

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-mir-ci/161/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

SIGSTOP seems like a weird choice. But if that's the requirement the code is OK

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:133
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/162/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/23/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-i386-ci/23

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-mir-ci/162/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-mir-autolanding/96/
Executed test runs:
    FAILURE: http://s-jenkins.ubuntu-ci:8080/job/generic-cleanup-mbs/3403/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-amd64-autolanding/18/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-autolanding/18/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-i386-autolanding/18/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches