Merge lp://qastaging/~gero-bare/scratch/fix-1392031-again into lp://qastaging/~elementary-apps/scratch/scratch
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://qastaging/~gero-bare/scratch/fix-1392031-again |
| Merge into: | lp://qastaging/~elementary-apps/scratch/scratch |
| Diff against target: |
143 lines (+22/-26) 2 files modified
src/MainWindow.vala (+8/-15) src/Widgets/SplitView.vala (+14/-11) |
| To merge this branch: | bzr merge lp://qastaging/~gero-bare/scratch/fix-1392031-again |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Danielle Foré | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Ok things to be tested.
> Open files using the file manager plugin.
> Open new SplitView, make sure that:
* new tabs (Ctrl-n) are opened in the right split view.
* files opened with the filemanager are opened in the right view.
* switch focus between views and test the same conditions.
etc.
Additional notes. Sometimes a view is closed and when reopened it opens all the previously opened files but sometimes not. I don't know if intended or not, I wont fix.
I found that opening files with folder icon, can sometimes open the same file twice in the same splitview, I couldn't reproduce reliably plus I found it in the middle of the iteration so be warned, but I don't think that it's entirely my fault. But I won't fix.
| Danielle Foré (danrabbit) wrote | # |
Unmerged revisions
- 1831. By Gero.Bare
-
* Fixed bug 1392031 again
* Removed calls to split_view.
get_focus_ child (), use get_current_view () instead.
Please make sure this doesn't break the folder sidebar