Merge lp://qastaging/~gesha/linaro-license-protection/non-recursive-search into lp://qastaging/~linaro-automation/linaro-license-protection/trunk

Proposed by Georgy Redkozubov
Status: Merged
Approved by: Stevan Radaković
Approved revision: 141
Merged at revision: 141
Proposed branch: lp://qastaging/~gesha/linaro-license-protection/non-recursive-search
Merge into: lp://qastaging/~linaro-automation/linaro-license-protection/trunk
Diff against target: 176 lines (+40/-67)
2 files modified
license_protected_downloads/render_text_files.py (+16/-6)
license_protected_downloads/tests/test_render_text_files.py (+24/-61)
To merge this branch: bzr merge lp://qastaging/~gesha/linaro-license-protection/non-recursive-search
Reviewer Review Type Date Requested Status
Stevan Radaković Approve
Linaro Infrastructure Pending
Review via email: mp+130979@code.qastaging.launchpad.net

Description of the change

This branch adds non-recursive search for README, INSTALL, etc. and for howto/HOWTO_* These files will be rendered only if found in current dir.
Made flash firmware instructions non-mandatory. Updated tests to reflect current state.

To post a comment you must log in.
Revision history for this message
Stevan Radaković (stevanr) wrote :

Hey gesha, this looks good.

One comment though, I don't think we should make flashfirmware non-mandatory so easy.
It should be put under discussion first in the email thread we had, I already told fabo about this.
This effects only android, and it was determined previously that it should have fallback links.
Let's remove it for now, it doesn't have to do anything with the bug were're fixing here.

review: Needs Fixing
141. By Georgy Redkozubov

Revert back HOWTO_flashfirmware.txt

Revision history for this message
Stevan Radaković (stevanr) wrote :

Thanks. Approve +1.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches