GTG

Merge lp://qastaging/~ghugesss/gtg/patches into lp://qastaging/~gtg/gtg/old-trunk

patches
Merge into old-trunk

Proposed by Sagar Ghuge on 2014-03-11

Status:	Merged
Merged at revision:	1368
Proposed branch:	lp://qastaging/~ghugesss/gtg/patches
Merge into:	lp://qastaging/~gtg/gtg/old-trunk
Diff against target:	38 lines (+3/-4) 1 file modified GTG/gtk/editor/taskview.py (+3/-4)
To merge this branch:	bzr merge lp://qastaging/~ghugesss/gtg/patches
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Nimit Shah	2014-03-13	Needs Fixing on 2014-03-14
Parin Porecha	2014-03-11	Needs Fixing on 2014-03-11
Review via email: mp+210341@code.qastaging.launchpad.net

Commit message

'.data' access removed, and replaced with the right method call

Description of the change

SelectionData patched

Revision history for this message

Parin Porecha (parinporecha) wrote on 2014-03-11:

Hi,

I receive this error traceback by doing a drag-n-drop in the task editor -

Traceback (most recent call last):
  File "/home/manhattan/GTG_POST_MERGE/trunk2/GTG/gtk/editor/taskview.py", line 185, in drag_receive
    self.buff.insert_at_cursor(selection.get_text())
  File "/usr/lib/python3.3/site-packages/gi/overrides/Gtk.py", line 703, in insert_at_cursor
    raise TypeError('text must be a string, not %s' % type(text))
TypeError: text must be a string, not <class 'NoneType'>

review: Needs Fixing

lp://qastaging/~ghugesss/gtg/patches updated on 2014-03-12

1365. By Sagar Ghuge on 2014-03-12: .data removed and right method called
1366. By Sagar Ghuge on 2014-03-12: unnecessary import removed

Revision history for this message

Nimit Shah (nimit-svnit) wrote on 2014-03-13:

What is the purpose of this merge? What issue does this wish to solve?
If it is preventing drag n drop of tasks in Workview then it is not working.

review: Needs Information

Revision history for this message

Sagar Ghuge (ghugesss) wrote on 2014-03-14:

Hi,

Issue which is noticed :-

http://bazaar.launchpad.net/~gtg/gtg/trunk/view/head:/GTG/gtk/editor/taskview.py#L185

.data is not a attribute of GtkSelectionData. so while draging any content
from any source to task editor it throws an error.

Considering this submitted patch.

I hope this much information is sufficient if not let me know.

On Fri, Mar 14, 2014 at 12:47 AM, Nimit Shah <email address hidden> wrote:

> Review: Needs Information
>
> What is the purpose of this merge? What issue does this wish to solve?
> If it is preventing drag n drop of tasks in Workview then it is not
> working.
> --
> https://code.launchpad.net/~ghugesss/gtg/patches/+merge/210341
> You are the owner of lp:~ghugesss/gtg/patches.
>

*Regards,Sagar*

Revision history for this message

Nimit Shah (nimit-svnit) wrote on 2014-03-14:

Hi Sagar,
Your fix seems to be duplicating the data of the task editor. I'll attach screenshots with the next mail.

review: Needs Fixing

lp://qastaging/~ghugesss/gtg/patches updated on 2014-03-16

1367. By Sagar Ghuge <email address hidden> on 2014-03-16: drag_receive changed.

Revision history for this message

Sagar Ghuge (ghugesss) wrote on 2014-03-16:

Hi Nimit,

I have updated branch. Can you review it now.

> Hi Sagar,
> Your fix seems to be duplicating the data of the task editor. I'll attach
> screenshots with the next mail.

Revision history for this message

Nimit Shah (nimit-svnit) wrote on 2014-03-16:

Hi Sagar,
You seem to have a pep8 error in your code. Please correct it and also,
update the copyright year of taskedview.py to 2008 - 2014.

Nimit Shah

On Sun, Mar 16, 2014 at 3:29 PM, Sagar Ghuge <email address hidden> wrote:

> Hi Nimit,
>
> I have updated branch. Can you review it now.
>
> > Hi Sagar,
> > Your fix seems to be duplicating the data of the task editor. I'll attach
> > screenshots with the next mail.
> --
> https://code.launchpad.net/~ghugesss/gtg/patches/+merge/210341
> You are reviewing the proposed merge of lp:~ghugesss/gtg/patches into
> lp:gtg.
>