Merge lp://qastaging/~gl-az/percona-xtrabackup/2.1-valgrind into lp://qastaging/percona-xtrabackup/2.1

Proposed by George Ormond Lorch III
Status: Superseded
Proposed branch: lp://qastaging/~gl-az/percona-xtrabackup/2.1-valgrind
Merge into: lp://qastaging/percona-xtrabackup/2.1
Diff against target: 198 lines (+97/-67)
1 file modified
utils/build.sh (+97/-67)
To merge this branch: bzr merge lp://qastaging/~gl-az/percona-xtrabackup/2.1-valgrind
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Needs Fixing
Review via email: mp+166407@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2013-07-12.

Description of the change

Added new environment variables to control build:
  MAKE_ONLY - Set this to 1 to only re 'make' the server and xtrabackup. Nothing will be downloaded, unpacked or patched. This is not advised if any compiler or other flags are being changed from previous builds.
  RELWITHDEBINFO - Set this to 1 to eliminate optimizations by changing C/CXXFLAGS to -g -O0 and pass CMAKE_BUILD_TYPE=RelWithDebInfo to PS or MySQL 5.5+ cmake.
  WITH_VALGRIND - Set this to 1 to perform Valgrind compatible build. Eliminates optimizations just like RELWITHDEBINFO and also passes WITH_VALGRIND=ON to PS or MySQL 5.5+ cmake.
Added innobackupex option --use-valgrind which will prefix backup and apply-log calls to xtrabackup with "valgrind".
The valgrind binary must be within path and valgrind options may be set by either using the ~/.valgrindrc file or setting the environment variable VALGRIND_OPTS.

To post a comment you must log in.
Revision history for this message
Stewart Smith (stewart) wrote :

This will probably conflict with https://code.launchpad.net/~stewart/percona-xtrabackup/source-dist-refactor/+merge/167709 as I've moved things about a bit with regards to downloading/unpacking things and it may have the same end result as MAKE_ONLY

610. By Alexey Kopytov

Bug #1190716: innobackupex --safe-slave-backup hangs when used on
              master

The problem was in uninitialized value usage in wait_for_safe_slave()
when the server is not a replication slave, i.e. when no values in
$con->{slave_status} are defined.

Fixed by moving the check for $con->{slave_status}->{Slave_SQL_Running}
after the check for $host_is_slave and checking if Slave_SQL_Running is
defined when setting $host_is_slave for extra-safety.

611. By <email address hidden>

Merge lp:~hrvojem/percona-xtrabackup/bug1181317

612. By Alexey Kopytov

Empty merge from 2.0.

613. By Alexey Kopytov

Merged lp:~sergei.glushchenko/percona-xtrabackup/BT30559-kill-long-selects.

614. By Alexey Kopytov

Merge lp:~stewart/percona-xtrabackup/test-more-parallel.

615. By Alexey Kopytov

Merged lp:~gl-az/percona-xtrabackup/2.1-bug1190610.

616. By Alexey Kopytov

Merged lp:~stewart/percona-xtrabackup/2.1-bug1028949-test-fast.

617. By Alexey Kopytov

Merged lp:~gl-az/percona-xtrabackup/2.1-bug1192347.

618. By Alexey Kopytov

Empty merge from 2.0.

619. By Alexey Kopytov

Automerge from 2.0.

620. By Alexey Kopytov

Merged lp:~akopytov/percona-xtrabackup/bugs-1177206-and-1187071-2.1.

621. By Alexey Kopytov

Empty merge from 2.0.

622. By Alexey Kopytov

Bug #1198220: xtrabackup typo: Temporary instance for recovery is set as
              followings

Corrected language in the mentioned messages.

623. By Alexey Kopytov

Merged lp:~stewart/percona-xtrabackup/deb-pkg-updates.

624. By Alexey Kopytov

Merged lp:~vlad-lesin/percona-xtrabackup/bug1182726-2.1.

Revision history for this message
Alexey Kopytov (akopytov) wrote :

This needs a bug/BP and rebasing on trunk (as source-dist-refactor has been merged to 2.1).

review: Needs Fixing
625. By Alexey Kopytov

Merged lp:~akopytov/percona-xtrabackup/test-suite-cleanups-2.1.

626. By Alexey Kopytov

Empty merge from 2.0.

627. By Alexey Kopytov

Merged lp:~gl-az/percona-xtrabackup/2.1-bug1197644.

628. By Alexey Kopytov

Manual merge from lp:~raghavendra-prabhu/percona-xtrabackup/2.1-Bug1182995.

629. By George Ormond Lorch III

Added new environment variables to control build:
  MAKE_ONLY - Set this to 1 to only re 'make' the server and xtrabackup. Nothing will be downloaded, unpacked or patched. This is not advised if any compiler or other flags are being changed from previous builds.
  RELWITHDEBINFO - Set this to 1 to eliminate optimizations by changing C/CXXFLAGS to -g -O0 and pass CMAKE_BUILD_TYPE=RelWithDebInfo to PS or MySQL 5.5+ cmake.
  WITH_VALGRIND - Set this to 1 to perform Valgrind compatible build. Eliminates optimizations just like RELWITHDEBINFO and also passes WITH_VALGRIND=ON to PS or MySQL 5.5+ cmake.
Added innobackupex option --use-valgrind which will prefix backup and apply-log calls to xtrabackup with "valgrind".
The valgrind binary must be within path and valgrind options may be set by either using the ~/.valgrindrc file or setting the environment variable VALGRIND_OPTS.

Unmerged revisions

629. By George Ormond Lorch III

Added new environment variables to control build:
  MAKE_ONLY - Set this to 1 to only re 'make' the server and xtrabackup. Nothing will be downloaded, unpacked or patched. This is not advised if any compiler or other flags are being changed from previous builds.
  RELWITHDEBINFO - Set this to 1 to eliminate optimizations by changing C/CXXFLAGS to -g -O0 and pass CMAKE_BUILD_TYPE=RelWithDebInfo to PS or MySQL 5.5+ cmake.
  WITH_VALGRIND - Set this to 1 to perform Valgrind compatible build. Eliminates optimizations just like RELWITHDEBINFO and also passes WITH_VALGRIND=ON to PS or MySQL 5.5+ cmake.
Added innobackupex option --use-valgrind which will prefix backup and apply-log calls to xtrabackup with "valgrind".
The valgrind binary must be within path and valgrind options may be set by either using the ~/.valgrindrc file or setting the environment variable VALGRIND_OPTS.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches