Ubuntu
mountall package

Merge lp://qastaging/~gleichsnerd/ubuntu/precise/mountall/fix-for-805509 into lp://qastaging/ubuntu/precise/mountall

  1. Precise (12.04)
  2. fix-for-805509
  3. Merge into precise
Proposed by Adam Gleichsner
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp://qastaging/~gleichsnerd/ubuntu/precise/mountall/fix-for-805509
Merge into: lp://qastaging/ubuntu/precise/mountall
Diff against target: 43 lines (+33/-0)
1 file modified
man/mountall.8 (+33/-0)
To merge this branch: bzr merge lp://qastaging/~gleichsnerd/ubuntu/precise/mountall/fix-for-805509
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Ubuntu branches Pending
Adam Gleichsner Pending
Micah Gersten Pending
Review via email: mp+107908@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-03-31.

Description of the change

As requested in #805509, I added the options for mountall to the man page, as written in mountall --help.

Testing is straightforward, just backup the old mountall man page and throw in this one. Everything should come out all squeaky clean and beautiful.

**5/29/12 -- Formatting updated/fixed; resubmitted

To post a comment you must log in.
Revision history for this message
Micah Gersten (micahg) wrote : Posted in a previous version of this proposal

This looks great, thanks. Are you ok with this patch being under Canonical copyright?

review: Needs Information
Revision history for this message
James Hunt (jamesodhunt) wrote : Posted in a previous version of this proposal

Hi Adam - thank you very much for your contribution. A few minor comments:

- All dashes ('-') should be escaped so rather than '--debug', you should specify '\-\-debug'.
- '--dev-wait-time=value' should be '\-\-dev\-wait\-time=\fIvalue\fP'.
- 'value' in '--dev-wait-time' is not underlined.
- Formatting is wrong for '--dev-wait-time'.
- '--quiet' and '--verbose' are not displaying in bold as the other options are.

Take a look at the init-checkconf(8) man page as this has examples of all the above scenarios:

    vim $(man -w init-checkconf)

Revision history for this message
Adam Gleichsner (gleichsnerd) wrote : Posted in a previous version of this proposal

Sorry for the hiatus, I had some hardware malfunctions that put me out of commission for awhile.

I fixed the formatting as per James' request. Hopefully it's all set to go now.

Let me know if anything else needs to be done.

-Adam

P.S. @Micah - The Canonical copyright is fine.

review: Needs Resubmitting
Revision history for this message
James Hunt (jamesodhunt) wrote :

Hi Adam,

Thanks very much for your work on this - looks great now!

(BTW - if you're interested, we don't yet have a man page for /sbin/mntctl in the mountall package).

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Merged in lp:ubuntu/mountall trunk after some discussion with jodh. Thanks! (this branch will be rejected as wrong target)

review: Approve
Revision history for this message
Adam Gleichsner (gleichsnerd) wrote :

@James Hunt,

I would be happy to. I just submitted a bug report to link to it; I'll get cracking right away.

Unmerged revisions

383. By Adam Gleichsner

Fixed formatting errors

382. By Adam Gleichsner

Added options to mountall(8) man page

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches