Merge lp://qastaging/~gmb/launchpad/new-subscriptions-widget-bug-616653 into lp://qastaging/launchpad
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Brad Crittenden | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 11413 | ||||
| Proposed branch: | lp://qastaging/~gmb/launchpad/new-subscriptions-widget-bug-616653 | ||||
| Merge into: | lp://qastaging/launchpad | ||||
| Diff against target: |
210 lines (+196/-0) 3 files modified
lib/lp/bugs/javascript/bug_subscription_widget.js (+85/-0) lib/lp/bugs/javascript/tests/test_bug_subscription_widget.html (+41/-0) lib/lp/bugs/javascript/tests/test_bug_subscription_widget.js (+70/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~gmb/launchpad/new-subscriptions-widget-bug-616653 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brad Crittenden (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
The first stage of a new subscription widget has been added to the lp.bugs Javascript.
Description of the change
This branch adds the beginnings of a new subscription widget. It isn't actually hooked up to anything yet.
The widget will first be used for bug subscriptions before being converted to work for both individual bugs *and* structural subscriptions. It will eventually be used for subscriptions-
The widget isn't, as I said, hooked up to anything; this branch is about giving us a good base to work from for the rest of the development work.
I've added a simple test to check that the values used for the bug notification level radio buttons are valid, but tests will become more thorough as more development work is carried out, since we'll be able to add Windmill tests, too.
Hi Graham,
Thanks for the preliminary work on this widget. As we discussed on IRC s/2009/2010 and s/2008/2010/
Also follow young Matthew's advice on the wording of the troublesome option.