Merge lp://qastaging/~gmb/lp2kanban/encode-annotations-with-json into lp://qastaging/~launchpad/lp2kanban/trunk
Proposed by
Graham Binns
| Status: | Merged |
|---|---|
| Merged at revision: | 65 |
| Proposed branch: | lp://qastaging/~gmb/lp2kanban/encode-annotations-with-json |
| Merge into: | lp://qastaging/~launchpad/lp2kanban/trunk |
| Prerequisite: | lp://qastaging/~gmb/lp2kanban/dont-rely-on-external_system_url |
| Diff against target: |
421 lines (+242/-121) 3 files modified
src/lp2kanban/kanban.py (+29/-26) src/lp2kanban/tests/test_bugs2cards.py (+3/-95) src/lp2kanban/tests/test_description_annotations.py (+210/-0) |
| To merge this branch: | bzr merge lp://qastaging/~gmb/lp2kanban/encode-annotations-with-json |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Benji York (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Card description annotations are now encoded with JSON.
Description of the change
This branch takes the description annotations work and tweaks it to use JSON for encoding rather than using a hand-rolled key=value store.
As suggested in the previous MP, the description text is split into three blocks: that found before the JSON, that found after the JSON and the JSON itself.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This branch looks good. I think using JSON for storing card annotations
will be a big win.
It would be nice if the JSON could be a little more free-form and not
confined to a single line. It would make perusing the data in the card
UI easier plus easing the occasional manual edit.
It should be pretty easy to do that with a regular expression. Here is
some code (and tests) that you might be able to use:
http://