Linaro Image Tools

Merge lp://qastaging/~gmdduf/linaro-image-tools/gauss-support into lp://qastaging/linaro-image-tools/11.11

gauss-support
Merge into trunk

Proposed by Bernard Park on 2013-05-19

Status:	Needs review
Proposed branch:	lp://qastaging/~gmdduf/linaro-image-tools/gauss-support
Merge into:	lp://qastaging/linaro-image-tools/11.11
Diff against target:	45 lines (+16/-1) 2 files modified linaro_image_tools/media_create/boards.py (+16/-0) linaro_image_tools/media_create/tests/test_media_create.py (+0/-1)
To merge this branch:	bzr merge lp://qastaging/~gmdduf/linaro-image-tools/gauss-support
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Milo Casagrande (community)		2013-05-19	Needs Fixing on 2013-05-23
Review via email: mp+164610@code.qastaging.launchpad.net

Description of the change

this patch support Samsung Gauss server platform

Revision history for this message

Milo Casagrande (milo) wrote on 2013-05-23:

Hi,

thanks for working on this.
There are a couple of errors that would need fixing:

./linaro_image_tools/media_create/boards.py:1692:1: E302 expected 2 blank lines, found 1
./linaro_image_tools/media_create/boards.py:1702:26: E222 multiple spaces after operator
./linaro_image_tools/media_create/boards.py:1705:26: E222 multiple spaces after operator
./linaro_image_tools/media_create/tests/test_media_create.py:1558:1: E302 expected 2 blank lines, found 1

Those were found running the tests locally.
Also, is it possible for you to add some simple test for the new board? You can take a look at linaro_image_tools/media_create/tests/test_media_create.py, and look for a board like HighBank. The tests basically can be pretty much the same.

Thanks.

review: Needs Fixing

Revision history for this message

Milo Casagrande (milo) wrote on 2013-05-27:

Hi,

we are going to release Linaro Image Tools this week, would you like this to land with the 13.05 release? I can easily fix those errors in case.