Charm Helpers

Merge lp://qastaging/~gnuoy/charm-helpers/get-hwaddr into lp://qastaging/charm-helpers

  1. get-hwaddr
  2. Merge into devel
Proposed by Liam Young
Status: Merged
Approved by: Gareth Woolridge
Approved revision: 106
Merged at revision: 104
Proposed branch: lp://qastaging/~gnuoy/charm-helpers/get-hwaddr
Merge into: lp://qastaging/charm-helpers
Diff against target: 73 lines (+23/-5)
3 files modified
charmhelpers/core/host.py (+10/-0)
tests/contrib/charmsupport/test_nrpe.py (+4/-5)
tests/core/test_host.py (+9/-0)
To merge this branch: bzr merge lp://qastaging/~gnuoy/charm-helpers/get-hwaddr
Reviewer Review Type Date Requested Status
Gareth Woolridge Approve
Review via email: mp+197172@code.qastaging.launchpad.net

Description of the change

* Fix to tests broken by previous nrpe update
* Function with test to get the hardware address for a given nic

To post a comment you must log in.
lp://qastaging/~gnuoy/charm-helpers/get-hwaddr updated
106. By Liam Young

Fix copy/pasta error in test_get_nic_hwaddr (s/mtu/hwaddr)

Revision history for this message
Gareth Woolridge (moon127) wrote :

Looks good to me with the update to the test as discussed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches