Juju Charms Collection
ceph package

Merge lp://qastaging/~gnuoy/charms/trusty/ceph/1453940 into lp://qastaging/~openstack-charmers-archive/charms/trusty/ceph/next

  1. Trusty Tahr (14.04)
  2. 1453940
  3. Merge into next
Proposed by Liam Young
Status: Merged
Merged at revision: 117
Proposed branch: lp://qastaging/~gnuoy/charms/trusty/ceph/1453940
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/ceph/next
Diff against target: 1195 lines (+885/-62)
7 files modified
hooks/ceph_broker.py (+12/-2)
hooks/charmhelpers/contrib/storage/linux/ceph.py (+224/-2)
hooks/hooks.py (+9/-1)
tests/charmhelpers/contrib/amulet/utils.py (+234/-52)
tests/charmhelpers/contrib/openstack/amulet/deployment.py (+20/-5)
tests/charmhelpers/contrib/openstack/amulet/utils.py (+359/-0)
unit_tests/test_ceph_broker.py (+27/-0)
To merge this branch: bzr merge lp://qastaging/~gnuoy/charms/trusty/ceph/1453940
Reviewer Review Type Date Requested Status
Edward Hope-Morley Approve
Review via email: mp+268614@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Edward Hope-Morley (hopem) :
Revision history for this message
Edward Hope-Morley (hopem) wrote :

I've tested this out and it seems good. Tried deploying then scaling for
ceph, cinder, glance and nova-compute and all had updated ceph.conf on the
client side. The use of request-id combined with unit-name scoped responses
seems to nicely avoid any collisions as well. I have a few comments on some
minor fixups inline.

review: Needs Fixing
Revision history for this message
Liam Young (gnuoy) :
Revision history for this message
Edward Hope-Morley (hopem) :
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #8678 ceph-next for gnuoy mp268614
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/8678/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #9384 ceph-next for gnuoy mp268614
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/9384/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6247 ceph-next for gnuoy mp268614
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6247/

lp://qastaging/~gnuoy/charms/trusty/ceph/1453940 updated
138. By Liam Young

Charm helper sync

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #8778 ceph-next for gnuoy mp268614
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/8778/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #9538 ceph-next for gnuoy mp268614
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/9538/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6308 ceph-next for gnuoy mp268614
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6308/

lp://qastaging/~gnuoy/charms/trusty/ceph/1453940 updated
139. By Liam Young

Charm helper sync

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #9710 ceph-next for gnuoy mp268614
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/9710/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #8943 ceph-next for gnuoy mp268614
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/8943/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6344 ceph-next for gnuoy mp268614
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6344/

Revision history for this message
Edward Hope-Morley (hopem) wrote :

LGTM +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches