Merge lp://qastaging/~gnuoy/charms/trusty/cinder-ceph/1453940-stable into lp://qastaging/~openstack-charmers-archive/charms/precise/cinder-ceph/trunk

Proposed by Liam Young
Status: Merged
Merged at revision: 36
Proposed branch: lp://qastaging/~gnuoy/charms/trusty/cinder-ceph/1453940-stable
Merge into: lp://qastaging/~openstack-charmers-archive/charms/precise/cinder-ceph/trunk
Diff against target: 751 lines (+357/-82)
12 files modified
hooks/charmhelpers/cli/__init__.py (+1/-5)
hooks/charmhelpers/cli/commands.py (+4/-4)
hooks/charmhelpers/cli/hookenv.py (+23/-0)
hooks/charmhelpers/contrib/openstack/context.py (+8/-9)
hooks/charmhelpers/contrib/openstack/utils.py (+7/-5)
hooks/charmhelpers/contrib/storage/linux/ceph.py (+224/-2)
hooks/charmhelpers/contrib/storage/linux/utils.py (+3/-2)
hooks/charmhelpers/core/hookenv.py (+1/-20)
hooks/charmhelpers/core/host.py (+2/-2)
hooks/cinder_hooks.py (+13/-22)
tests/basic_deployment.py (+52/-8)
unit_tests/test_cinder_hooks.py (+19/-3)
To merge this branch: bzr merge lp://qastaging/~gnuoy/charms/trusty/cinder-ceph/1453940-stable
Reviewer Review Type Date Requested Status
Chris Glass (community) Approve
Ryan Beisner (community) Needs Fixing
Review via email: mp+271261@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #9552 cinder-ceph for gnuoy mp271261
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9552/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #10411 cinder-ceph for gnuoy mp271261
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/10411/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6551 cinder-ceph for gnuoy mp271261
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12514387/
Build: http://10.245.162.77:8080/job/charm_amulet_test/6551/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #10436 cinder-ceph for gnuoy mp271261
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/10436/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #9629 cinder-ceph for gnuoy mp271261
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9629/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6578 cinder-ceph for gnuoy mp271261
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12521251/
Build: http://10.245.162.77:8080/job/charm_amulet_test/6578/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

To save you the time of grepping logs, that amulet fail is real.

00:17:33.288 2015-09-22 13:59:57,026 test_201_ceph_cinderceph_ceph_relation DEBUG: Checking ceph:client to cinder-ceph:ceph relation data...

...

00:17:33.289 Broker request invalid or failed: None

review: Needs Fixing
Revision history for this message
Liam Young (gnuoy) wrote :

OSCI failure caused by ceph having not landed yet.

38. By Liam Young

Empty commit to trigger osci

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #9652 cinder-ceph for gnuoy mp271261
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9652/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6585 cinder-ceph for gnuoy mp271261
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12521979/
Build: http://10.245.162.77:8080/job/charm_amulet_test/6585/

39. By Liam Young

Empty commit to trigger osci

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #9654 cinder-ceph for gnuoy mp271261
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9654/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #10463 cinder-ceph for gnuoy mp271261
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/10463/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6606 cinder-ceph for gnuoy mp271261
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12526301/
Build: http://10.245.162.77:8080/job/charm_amulet_test/6606/

40. By Liam Young

Empty commit to kick osci

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #9712 cinder-ceph for gnuoy mp271261
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9712/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #10524 cinder-ceph for gnuoy mp271261
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/10524/

Revision history for this message
Liam Young (gnuoy) wrote :

Since the latest revision of ceph is still not in the charm store I tests an amulet run manually with the latest ceph from stable. It LGTM http://paste.ubuntu.com/12529898/

Revision history for this message
Chris Glass (tribaal) wrote :

After further testing on a bastion, this should pass. In order to cut down on wait time I'm going to go ahead and merge this already.

+1

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6666 cinder-ceph for gnuoy mp271261
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6666/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches