Merge lp://qastaging/~gnuoy/charms/trusty/cisco-vpp/deb-get-fix into lp://qastaging/~openstack-charmers/charms/trusty/cisco-vpp/next
Proposed by
Liam Young
| Status: | Merged |
|---|---|
| Merged at revision: | 114 |
| Proposed branch: | lp://qastaging/~gnuoy/charms/trusty/cisco-vpp/deb-get-fix |
| Merge into: | lp://qastaging/~openstack-charmers/charms/trusty/cisco-vpp/next |
| Diff against target: |
217 lines (+19/-93) 4 files modified
hooks/ODL.py (+2/-1) hooks/services.py (+0/-2) hooks/vpp_utils.py (+5/-11) unit_tests/test_vpp_utils.py (+12/-79) |
| To merge this branch: | bzr merge lp://qastaging/~gnuoy/charms/trusty/cisco-vpp/deb-get-fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| OpenStack Charmers | Pending | ||
|
Review via email:
|
|||
Description of the change
urllib was failing when trying to download the vpe.deb via MAAS' squid proxy. However, using the requests lib fixed the issue and since requests is used everywhere else in the charm it makes sense to switch to using it for retrieving the deb.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
