Merge lp://qastaging/~gnuoy/charms/trusty/hacluster/ipv4mtu into lp://qastaging/~openstack-charmers/charms/trusty/hacluster/next

Proposed by Liam Young
Status: Merged
Merge reported by: Edward Hope-Morley
Merged at revision: not available
Proposed branch: lp://qastaging/~gnuoy/charms/trusty/hacluster/ipv4mtu
Merge into: lp://qastaging/~openstack-charmers/charms/trusty/hacluster/next
Diff against target: 34 lines (+3/-3)
2 files modified
config.yaml (+1/-1)
hooks/hooks.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~gnuoy/charms/trusty/hacluster/ipv4mtu
Reviewer Review Type Date Requested Status
Edward Hope-Morley Approve
Review via email: mp+256117@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #3110 hacluster-next for gnuoy mp256117
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/3110/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #3322 hacluster-next for gnuoy mp256117
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/3322/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #3143 hacluster-next for gnuoy mp256117
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/10820974/
Build: http://10.245.162.77:8080/job/charm_amulet_test/3143/

Revision history for this message
Edward Hope-Morley (hopem) :
review: Needs Fixing
45. By Liam Young

Take out ipv6 special case as per mp comment

Revision history for this message
Edward Hope-Morley (hopem) wrote :

lgtm +1

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #3113 hacluster-next for gnuoy mp256117
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/3113/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #3325 hacluster-next for gnuoy mp256117
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/3325/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #3146 hacluster-next for gnuoy mp256117
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/10821081/
Build: http://10.245.162.77:8080/job/charm_amulet_test/3146/

46. By Liam Young

Only need to set mtu once

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #3116 hacluster-next for gnuoy mp256117
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/3116/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #3328 hacluster-next for gnuoy mp256117
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/3328/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #3149 hacluster-next for gnuoy mp256117
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/10821183/
Build: http://10.245.162.77:8080/job/charm_amulet_test/3149/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: