Merge lp://qastaging/~gnuoy/charms/trusty/hacluster/uidgid-dir into lp://qastaging/~openstack-charmers/charms/trusty/hacluster/next

Proposed by Liam Young
Status: Merged
Merged at revision: 65
Proposed branch: lp://qastaging/~gnuoy/charms/trusty/hacluster/uidgid-dir
Merge into: lp://qastaging/~openstack-charmers/charms/trusty/hacluster/next
Diff against target: 250 lines (+68/-23)
6 files modified
hooks/charmhelpers/contrib/network/ip.py (+9/-0)
hooks/charmhelpers/contrib/openstack/utils.py (+6/-3)
hooks/charmhelpers/core/host.py (+30/-8)
hooks/utils.py (+4/-1)
tests/charmhelpers/contrib/amulet/utils.py (+16/-10)
tests/charmhelpers/contrib/openstack/amulet/deployment.py (+3/-1)
To merge this branch: bzr merge lp://qastaging/~gnuoy/charms/trusty/hacluster/uidgid-dir
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+291627@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2248 hacluster-next for gnuoy mp291627
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/2248/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1801 hacluster-next for gnuoy mp291627
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/1801/

66. By Liam Young

CH sync

Revision history for this message
James Page (james-page) wrote :

This looks reasonable to me

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2249 hacluster-next for gnuoy mp291627
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/2249/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1802 hacluster-next for gnuoy mp291627
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/1802/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #700 hacluster-next for gnuoy mp291627
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/700/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #701 hacluster-next for gnuoy mp291627
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/701/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: